LTD-6077: Update permissions and remove security grading from Recommendation #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this permission fails if same user tries to post recommendations again on a case but now the OGD recommendation flow is updated to select multiple entities at a time. User may either select all or subset of entities at a time and he will have to post multiple times to make recommendations on all entities. So remove this check from this permission and allow the user to post multiple times.
currycoder
approved these changes
Apr 3, 2025
|
I am going to update this to remove security_grading from Recommendation model |
Users not expected to change this field when adding their recommendation as it further complicates grouping so removing this field.
saruniitr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
OGD Recommendation flow is being updated to select multiple entities. In this case user can either select all or subset of entities and should be able to POST multiple times hence relax this permission to allow this.
FE PR is uktrade/lite-frontend#2443