-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the new Unity Input System #1676
base: develop
Are you sure you want to change the base?
Conversation
Just tried pulling that branch and then using the physical hands example scene. Using Unity 2022.3 and a clean project with the XT Template. I see this (see below). Perhaps some of our samples are set up not to use the new input system? |
That's possible, I was ensuring that all the places where the old input system was used also had pathways for the new input system in parallel. I'll pull that example and take a look. |
Ah, looks like we need to go through the samples and search for EventSystem, then hit this button? (Yes, that clears out the warnings) |
Ah OK, then yes we should update the samples by default to the new system I think? |
Yes, I think so. |
I double-checked the code regarding the two versions of the tracked pose driver, it already handles both of those cases correctly. However, we may also want to convert the samples to use the new |
This script is only used in the Editor, so this is the correct way to handle input listening and will work no matter the input system that's currently in use.
3f370c6
to
10fc84d
Compare
…o use the new Input System UIInput Module
…mples and examples that use the (old) Unity Input Manager
…te does not change to On if toggled to the on state
I've rebased this now to avoid a duplication of all the copyright changes. |
I fixed a few errors that I noticed during review with the preview package's import all examples script. I had to rename the samples to match the folders to get consistent behaviour again (other wise it gets imported with the display name which isn't very helpful), it was also missing an import to the base examples package for the |
What other changes did you make to the scene files, as at first glance they are still using "Input Pose Driver"? |
Summary
This ensures that all the parts of the main Ultraleap Tracking package support the new Unity Input System.
Only the
UIInputModule
in the Tracking Preview package and the controller example for the input manager does not work with this system. These have been split into a set of examples for the input manager (old) from the existing tracking preview examples which are now the main examples. There is also a common set of example assets that need to be imported for both example 'packages' to work.While splitting/moving the examples, a couple of issue have been fixed with the UI input scene
Contributor Tasks
Test Cycle
Link to the test cycle here.
Reviewer Tasks
Related JIRA Issues
If this MR closes any JIRA issues list them below in the form
Closes PROJECT-#
Pull Request Templates
Switch template by going to preview and clicking the link - note it will not work if you've made any changes to the description.
You are currently using: default.md
Note: these links work by overwriting query parameters of the current url. If the current url contains any you may want to amend the url with
&template=name.md
instead of using the link. See query parameter docs for more information.