[FEAT]: Implement husky and update contribution guide for commit linting#35
[FEAT]: Implement husky and update contribution guide for commit linting#35AshutoshDash1999 wants to merge 3 commits into
Conversation
Ishwarpatra
left a comment
There was a problem hiding this comment.
@AshutoshDash1999
As a mentor, I must enforce the standards we set. There is a glaring irony in this PR: the commit messages and PR title violate the exact Conventional Commits rules being introduced in this change.
If the commit linting hooks were active, this PR’s branch would have been rejected at the command line.
Issues & Violations
PR Title & Commit Message Violations:
Current Title/Commit: [FEAT]: Implement husky and update contribution guide for commit linting #35
Violations:
The type is written in uppercase and wrapped in brackets ([FEAT]). This violates your configuration rule: 'type-case': [2, 'always', 'lower-case'].
The subject line begins with a capital letter (Implement...) and uses mixed case (Implement husky...). This violates your configuration rule: 'subject-case': [2, 'always', 'lower-case'].
Husky v9 Hook Setup:
The .husky/commit-msg script is set up correctly for Husky v9.
package.json contains "prepare": "husky install". Note that in Husky v9, husky install has been deprecated in favor of just husky. Using "prepare": "husky" is the recommended convention for newer versions.
|
@Ishwarpatra if you have checked the issue and related changes correctly, the change is about "commit linting" and not "PR". What you are referring is called "Pull Request Template". I can create a seperate issue for that and raise PR as well. |
|
@AshutoshDash1999 please resolve the conflicts |
|
@umang24-cyber I have resolved, please check |
Description
How to test
Closes #18