Skip to content

[FEAT]: Implement husky and update contribution guide for commit linting#35

Open
AshutoshDash1999 wants to merge 3 commits into
umang24-cyber:mainfrom
AshutoshDash1999:feat/husky-setup
Open

[FEAT]: Implement husky and update contribution guide for commit linting#35
AshutoshDash1999 wants to merge 3 commits into
umang24-cyber:mainfrom
AshutoshDash1999:feat/husky-setup

Conversation

@AshutoshDash1999

Copy link
Copy Markdown

Description

  • Implement Husky for commit linting
  • Enforce conventional commits

How to test

  • Write a bad commit message and push (it will be reject)
  • Write a good commit message and push (it will be accepted)

Closes #18

@Ishwarpatra Ishwarpatra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshutoshDash1999
As a mentor, I must enforce the standards we set. There is a glaring irony in this PR: the commit messages and PR title violate the exact Conventional Commits rules being introduced in this change.

If the commit linting hooks were active, this PR’s branch would have been rejected at the command line.

Issues & Violations
PR Title & Commit Message Violations:

Current Title/Commit: [FEAT]: Implement husky and update contribution guide for commit linting #35
Violations:
The type is written in uppercase and wrapped in brackets ([FEAT]). This violates your configuration rule: 'type-case': [2, 'always', 'lower-case'].
The subject line begins with a capital letter (Implement...) and uses mixed case (Implement husky...). This violates your configuration rule: 'subject-case': [2, 'always', 'lower-case'].
Husky v9 Hook Setup:

The .husky/commit-msg script is set up correctly for Husky v9.
package.json contains "prepare": "husky install". Note that in Husky v9, husky install has been deprecated in favor of just husky. Using "prepare": "husky" is the recommended convention for newer versions.

@Ishwarpatra Ishwarpatra changed the title [FEAT]: Implement husky and update contribution guide for commit linting feat(ci): implement husky and update contribution guide for commit linting Jun 26, 2026
@AshutoshDash1999

Copy link
Copy Markdown
Author

@Ishwarpatra if you have checked the issue and related changes correctly, the change is about "commit linting" and not "PR". What you are referring is called "Pull Request Template".

I can create a seperate issue for that and raise PR as well.

@AshutoshDash1999 AshutoshDash1999 changed the title feat(ci): implement husky and update contribution guide for commit linting [FEAT]: Implement husky and update contribution guide for commit linting Jun 26, 2026
@umang24-cyber

Copy link
Copy Markdown
Owner

@AshutoshDash1999 please resolve the conflicts

@AshutoshDash1999

Copy link
Copy Markdown
Author

@umang24-cyber I have resolved, please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] : Husky implementation for commit linting

3 participants