Block editors: adds prefix to workspace title (closes #20588) #20884
+25
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds prefixes ("Add" or "Edit") to block workspace titles to prevent empty browser titles when a block item has an empty label (e.g., when using a UFM label that exclusively references a property value that's not yet set).
- Moved the workspace title generation logic from
block-workspace-editor.element.tstoblock-workspace.context.ts - Enhanced the
#renderLabelmethod to include settings values and generate prefixed titles based on the block'sisNewstate - Simplified the
block-workspace-editor.element.tsto observe and display the already-formatted name
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/block-workspace.context.ts | Adds logic to prefix workspace titles with "Add" or "Edit" based on isNew state; includes settings values in label rendering and generates titles with localization key prefixes |
| src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/block-workspace-editor.element.ts | Simplifies headline generation by removing the localization logic and observing the pre-formatted name from context; removes unused imports |
src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/block-workspace.context.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #20588.
When a Block item has a label which is rendered empty (e.g. a UFM label that exclusively uses a property value), the leading fragment of the browser's title is empty, (e.g. it would display as
| Content | Umbraco, see #20588 for details).To note, if the Block item has a label which has a value (isn't empty), then that will display in the browser's title.
This PR looks to add a prefix to the Block workspace's label, with either "Add" or "Edit" (depending on the
isNewstate). This way, if the Block item's label is empty, the prefix will still be used. (To note, these prefixes use localization keys, e.g.general_add,general_edit).How to test?
With either a Block Grid or Block List editor, try adding a new block item, notice that the modal workspace headline and browser title is prefixed with "Add". Try editing an existing block item, notice that the modal workspace headline and browser title is now prefixed with "Edit".