LIBFCREPO-1788. Allow separate fcrepo endpoint URI and origin URL.#542
Open
peichman-umd wants to merge 1 commit intohotfix/2.0.3from
Open
LIBFCREPO-1788. Allow separate fcrepo endpoint URI and origin URL.#542peichman-umd wants to merge 1 commit intohotfix/2.0.3from
peichman-umd wants to merge 1 commit intohotfix/2.0.3from
Conversation
- converted the ResourceService from class methods only to an instance-based class - instantiated with the endpoint, optional origin, and optional auth token - added a ResourceServiceConcern mixin to add a `resource_service` method to controllers - used the ResourceServiceConcern with ResourceController and RetrieveController - switched environment variables and global constants from FCREPO_BASE_URL and REPO_EXTERNAL_URL to FCREPO_ENDPOINT (for the canoncal URI) and FCREPO_ORIGIN (for the cluster-internal URL) https://umd-dit.atlassian.net/browse/LIBFCREPO-1788
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resource_servicemethod to controllershttps://umd-dit.atlassian.net/browse/LIBFCREPO-1788