Skybox + New Terrain #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
qhdwight
reviewed
Feb 16, 2025
qhdwight
reviewed
Feb 16, 2025
qhdwight
reviewed
Feb 16, 2025
qhdwight
reviewed
Feb 16, 2025
qhdwight
reviewed
Feb 16, 2025
qhdwight
reviewed
Feb 16, 2025
qhdwight
reviewed
Feb 16, 2025
|
Did you intend to have it render in the virtual cameras too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What features did you add, bugs did you fix, etc?
Added new render pipeline, shaders, and textures for a skybox to make sim look nicer. Also added new meshes and textures for more realistic terrain. Also fixed sim cursor grabbing (no more Wayland cursor issues!!).
Did you add documentation to the wiki?
No
How was this code tested?
Tested sim with new features. Skybox does not seem to come with any noticeable performance penalty.
New terrain is disabled by default (but can be used by editing
simulator.yamlto usemars.urdf.xacroinstead ofworld.urdf.xacro) because it may be difficult to run on some computers.Did you test this in sim?
Yes
Did you test this on the rover?
N/A
Did you add unit tests?
No