Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleaning and editing #6

Merged
merged 11 commits into from
Jul 3, 2022
Merged

Code cleaning and editing #6

merged 11 commits into from
Jul 3, 2022

Conversation

abdoachhoubi
Copy link
Contributor

I replaced a legacy code in client/src/index.js from:

ReactDOM.render(
<React.StrictMode>
    <BrowserRouter>
      <App />
    </BrowserRouter>
  </React.StrictMode>,
document.getElementById("root")
);

to:

const root = ReactDOM.createRoot(document.getElementById("root"));
root.render(
<React.StrictMode>
    <BrowserRouter>
      <App />
    </BrowserRouter>
  </React.StrictMode>
);

I also added an export file in the client/src/component

I added some info in manifest.json and cleaned up index.html

I still need more information about the project to create a nice README.md file

@Pericles001
Copy link
Collaborator

I replaced a legacy code in client/src/index.js from:

ReactDOM.render(
<React.StrictMode>
    <BrowserRouter>
      <App />
    </BrowserRouter>
  </React.StrictMode>,
document.getElementById("root")
);

to:

const root = ReactDOM.createRoot(document.getElementById("root"));
root.render(
<React.StrictMode>
    <BrowserRouter>
      <App />
    </BrowserRouter>
  </React.StrictMode>
);

I also added an export file in the client/src/component

I added some info in manifest.json and cleaned up index.html

Have you tested the client site after your updates and it was working ?

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Collaborator

@Pericles001 Pericles001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did well but add the requested changes for approval

README.md Outdated Show resolved Hide resolved

## Contributors

## Acknowledgments
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client/public/index.html Show resolved Hide resolved
client/src/App.js Show resolved Hide resolved
client/src/index.js Show resolved Hide resolved
client/public/index.html Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@abdoachhoubi
Copy link
Contributor Author

You did well but add the requested changes for approval

Sure!

abdoachhoubi and others added 2 commits July 1, 2022 16:57
Co-authored-by: Pericles Adjovi <[email protected]>
Co-authored-by: Pericles Adjovi <[email protected]>
@Pericles001
Copy link
Collaborator

Merging this pull request should resolve issue #4

@abdoachhoubi
Copy link
Contributor Author

abdoachhoubi commented Jul 1, 2022

Merging this pull request should resolve issue #4

@Pericles001 Maybe but we still need to add more info in the README file.
I'll keep on adding information if I get more details about the project.

@Pericles001
Copy link
Collaborator

Merging this pull request should resolve issue #4

@Pericles001 Maybe but we still need to add more info in the README file. I'll keep on adding information if I get more details about the project.

Merging this pull request should resolve issue #4

@Pericles001 Maybe but we still need to add more info in the README file. I'll keep on adding information if I get more details about the project.

That is true. You will be assigned for further updates ...

@abdoachhoubi
Copy link
Contributor Author

I'll be happy to contribute anytime! ✌️

@Pericles001 Pericles001 merged commit 7d17a1b into underscoDe:main Jul 3, 2022
@abdoachhoubi abdoachhoubi deleted the alpha branch July 14, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants