Refactored AppleTV integration with new structure#107
Refactored AppleTV integration with new structure#107albaintor wants to merge 9 commits intounfoldedcircle:mainfrom
Conversation
Fix indentation issue in add_device function.
Corrected the comment to include a period at the end.
zehnm
left a comment
zehnm
left a comment
There was a problem hiding this comment.
Please fix the linting error. PRs must pass the automated tests.
Smaller PRs with one change only are highly appreciated. It greatly simplifies reviewing them and getting changes merged more quickly.
E.g. there are too many changes in the driver.py file and it can't be easily diffed anymore, since it was moved and heavily changed with the extraction of the MediaPlayer functionality.
One PR with project structure refactoring and another one with extracting the MediaPlayer and eventually another one with further changes.
|
Hi, I have removed some changes, moving of files in particular. |
zehnm
left a comment
zehnm
left a comment
There was a problem hiding this comment.
PRs must pass the automated checks.
Please fix the linting issues, then I'll check the PR.
| <inspection_tool class="PyUnresolvedReferencesInspection" enabled="true" level="WARNING" enabled_by_default="true"> | ||
| <option name="ignoredIdentifiers"> | ||
| <list> | ||
| <option value="pyelectroluxocp.oneAppApi.OneAppApi.*" /> |
There was a problem hiding this comment.
This seems to be from another project
| FeatureName, | ||
| FeatureState, | ||
| InputAction, | ||
| MediaType, |
There was a problem hiding this comment.
You have updated ucapi to 0.6.0 in requirements.txt that renamed MediaType to MediaContentType: https://github.com/unfoldedcircle/integration-python-library/releases/tag/v0.6.0
If you don't need new features from 0.6.0 or fixed all breaking changes, then the ucapi udpate should be in a separate PR. Otherwise, integrate all breaking changes in this PR.
There was a problem hiding this comment.
This is not the MediaType from ucapi but from pyatv : I imported this pyatv.MediaType to define a mapping to ucapi.MediaContentType
If you want I can revert all changes from 0.6.0 to keep only this one
2 participants
Hi,
I refactored the code of AppleTV integration like the others and to be able to handle additional entity types
It is tested locally and it works so far on my system
I also used the new Python integration API from repository which explains the build error