Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the IR_EMITTER entity type to the ucapi library by extending the EntityTypes enum.
- Adds IR_EMITTER as a new entity type option in the EntityTypes enum
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zehnm
approved these changes
Sep 7, 2025
Contributor
zehnm
left a comment
zehnm
left a comment
There was a problem hiding this comment.
Thanks!
And a good reminder to add this in the integration-node-library as well :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One liner to add IR_EMITTER to the list of supported EntityTypes.
You can almost get away with passing in a string but line 76
_LOG.debug("Created %s entity: %s", self.entity_type.value, self.id)is expecting an Enum. So you have to define a local EntityTypes Enum and pass that in to keep things moving which felt like just enough to open a pull request. :)Keep up the great work!