Dynamic header height on page view#13
Open
dwffls wants to merge 3 commits intounfoldedcircle:mainfrom
Open
Conversation
Author
|
@martonborzak and/or @zehnm any change of implementing this pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all I'd like to start by saying that I love the remote.
One of the small things that was bothering me however with the UI was that the header image did not fill to the top of the view when over scrolling. See also screenshot attached for visual clarification.
This pull request adds this change.
EDIT: Also updated the translation files as where necessary and removed a small bug where the header was movable when no items in list view. Thus allowing it to be moved over the "Press and hold home button..." message