Add desktop, metainfo and screenshot files for Flatpak #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I was in the process of submitting the Flatpak under the new app ID, a reviewer noted that these files should be stored in upstream repository. So we do that here. The metainfo file should be updated as we release a new version; the first `<release>` tag in `<releases>` should be updated as we make changes to the app. Signed-off-by: rany <[email protected]>
|
P.S. seeing that this is going be done, I'll try to get the screenshots added as well. |
9 tasks
This patch adds three screenshots of the browser of the about and welcome page to be used by different platforms, for example as images in app stores. See flathub/com.github.Eloston.UngoogledChromium#59 Co-authored-by: rany <[email protected]> Signed-off-by: rany <[email protected]>
rany2
changed the title
|
I guess this supersedes #1971 |
|
hm I'm not sure I like having platform specific metadata here, is it possible to have all the flatpak specific things in a repository under this organization instead? |
|
@networkException I'll ask, I'm not sure about Flathub's current policies but what I've seen so far is that it is stored in the main repository. |
|
I really hate this too because it makes updating more complicated for me and we always risk forgetting to update the metainfo file... this sucks |
|
It appears that I'm allowed to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was in the process of submitting the Flatpak under the new app ID, a reviewer noted that these files should be stored in upstream repository. So we do that here.
The metainfo file should be updated as we release a new version; the first
<release>tag in<releases>should be updated as we make changes to the app.CC @networkException