Skip to content

fix: prevent maximum call stack size exceeded in metro #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpudysz merged 1 commit into from
Jan 21, 2026
Merged

fix: prevent maximum call stack size exceeded in metro #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions packages/uniwind/src/metro/resolvers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { CustomResolutionContext, CustomResolver } from 'metro-resolver'
import { basename, resolve, sep } from 'node:path'
import { name } from '../../package.json'
import { basename, dirname, sep } from 'node:path'

type ResolverConfig = {
platform: string | null
Expand All @@ -9,10 +8,7 @@ type ResolverConfig = {
moduleName: string
}

const thisModuleDist = resolve(__dirname, '../../dist')
const thisModuleSrc = resolve(__dirname, '../../src')

const isFromThisModule = (filename: string) => filename.startsWith(thisModuleDist) || filename.startsWith(thisModuleSrc)
let cachedComponentsBasePath: string | null = null

const SUPPORTED_COMPONENTS = [
'ActivityIndicator',
Expand Down Expand Up @@ -46,7 +42,16 @@ export const nativeResolver = ({
resolver,
}: ResolverConfig) => {
const resolution = resolver(context, moduleName, platform)
const isInternal = isFromThisModule(context.originModulePath)

if (cachedComponentsBasePath === null) {
const componentsResolution = resolver(context, 'uniwind/components', platform)

cachedComponentsBasePath = componentsResolution.type === 'sourceFile'
? dirname(componentsResolution.filePath)
: ''
}

const isInternal = cachedComponentsBasePath !== '' && context.originModulePath.startsWith(cachedComponentsBasePath)
const isFromReactNative = context.originModulePath.includes(`${sep}react-native${sep}`)
|| context.originModulePath.includes(`${sep}@react-native${sep}`)
const isReactNativeAnimated = context.originModulePath.includes(`${sep}Animated${sep}components${sep}`)
Expand All @@ -56,7 +61,7 @@ export const nativeResolver = ({
}

if (moduleName === 'react-native') {
return resolver(context, `${name}/components`, platform)
return resolver(context, `uniwind/components`, platform)
}

if (
Expand All @@ -66,7 +71,7 @@ export const nativeResolver = ({
const module = filename.split('.').at(0)

if (module !== undefined && SUPPORTED_COMPONENTS.includes(module)) {
return resolver(context, `${name}/components/${module}`, platform)
return resolver(context, `uniwind/components/${module}`, platform)
}
}

Expand All @@ -81,8 +86,15 @@ export const webResolver = ({
}: ResolverConfig) => {
const resolution = resolver(context, moduleName, platform)

if (cachedComponentsBasePath === null) {
const componentsResolution = resolver(context, 'uniwind/components', platform)

cachedComponentsBasePath = componentsResolution.type === 'sourceFile'
? dirname(componentsResolution.filePath)
: ''
}
if (
isFromThisModule(context.originModulePath)
(cachedComponentsBasePath !== '' && context.originModulePath.startsWith(cachedComponentsBasePath))
|| resolution.type !== 'sourceFile'
|| !resolution.filePath.includes(`${sep}react-native-web${sep}`)
) {
Expand All @@ -97,5 +109,5 @@ export const webResolver = ({
return resolution
}

return resolver(context, `${name}/components/${module}`, platform)
return resolver(context, `uniwind/components/${module}`, platform)
}