You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Optimized border color property handling to automatically consolidate individual border side colors (top, right, bottom, left) into a single border color property when all sides are equal. This results in cleaner, more efficient styling output.
Reviewing files that changed from the base of the PR and between 514d826 and 8b5ebef.
📒 Files selected for processing (1)
packages/uniwind/src/metro/processor/rn.ts
📝 Walkthrough
Walkthrough
A new BORDER_COLOR_KEYS constant is introduced and logic is added to the joinStyles function in the metro processor. When all four individual border color properties (top, right, bottom, left) are present with matching values, they are coalesced into a single borderColor property, mirroring existing border width consolidation behavior.
Changes
Cohort / File(s)
Summary
Border color coalescing packages/uniwind/src/metro/processor/rn.ts
Added BORDER_COLOR_KEYS constant and logic to combine four per-side border color properties into a single borderColor shorthand when all keys exist with equal values.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
PR #285: Implements analogous border width joining logic in the same file, establishing the pattern this change follows for border color consolidation.
Poem
🐰 Four colors meet at borders' seam,
Top, right, bottom, left—a dreamy team!
When all agree on hues so bright,
One color wins—the code's delight! ✨
✨ Finishing Touches
📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/merge-border-colors
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit