Skip to content

fix: merge border colors parsing#414

Merged
Brentlok merged 1 commit into
mainfrom
fix/merge-border-colors
Feb 26, 2026
Merged

fix: merge border colors parsing#414
Brentlok merged 1 commit into
mainfrom
fix/merge-border-colors

Conversation

@Brentlok

@Brentlok Brentlok commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Refactor
    • Optimized border color property handling to automatically consolidate individual border side colors (top, right, bottom, left) into a single border color property when all sides are equal. This results in cleaner, more efficient styling output.

@Brentlok Brentlok merged commit 58a6051 into main Feb 26, 2026
1 of 2 checks passed
@coderabbitai

coderabbitai Bot commented Feb 26, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 514d826 and 8b5ebef.

📒 Files selected for processing (1)
  • packages/uniwind/src/metro/processor/rn.ts

📝 Walkthrough

Walkthrough

A new BORDER_COLOR_KEYS constant is introduced and logic is added to the joinStyles function in the metro processor. When all four individual border color properties (top, right, bottom, left) are present with matching values, they are coalesced into a single borderColor property, mirroring existing border width consolidation behavior.

Changes

Cohort / File(s) Summary
Border color coalescing
packages/uniwind/src/metro/processor/rn.ts
Added BORDER_COLOR_KEYS constant and logic to combine four per-side border color properties into a single borderColor shorthand when all keys exist with equal values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • PR #285: Implements analogous border width joining logic in the same file, establishing the pattern this change follows for border color consolidation.

Poem

🐰 Four colors meet at borders' seam,
Top, right, bottom, left—a dreamy team!
When all agree on hues so bright,
One color wins—the code's delight! ✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/merge-border-colors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Brentlok Brentlok deleted the fix/merge-border-colors branch February 26, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant