fix: custom-agent ?url= deep link - normalize scheme + dev SPA fallback#385
Merged
Conversation
Opening an external app via /agents/custom?url= failed two ways. (1) AgentPage called new URL() on the raw param, so a scheme-less host (boxy-run.fly.dev) threw and fell back to the prompt instead of the iframe; it now normalizes the scheme via a shared src/utils/normalizeUrl.ts that the in-app prompt (DesktopLayout) also uses. (2) The dev SPA fallback in vite.config.ts classified requests by the full URL including the query, so a query value with dots (?url=...fly.dev) was treated as a static asset and 404'd; it now strips the query before the asset check. The GitHub Pages 404.html redirect is unchanged (it already preserves the query).
igmahl
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening an external app via /agents/custom?url= failed two ways. (1) AgentPage called new URL() on the raw param, so a scheme-less host (boxy-run.fly.dev) threw and fell back to the prompt instead of the iframe; it now normalizes the scheme via a shared src/utils/normalizeUrl.ts that the in-app prompt (DesktopLayout) also uses. (2) The dev SPA fallback in vite.config.ts classified requests by the full URL including the query, so a query value with dots (?url=...fly.dev) was treated as a static asset and 404'd; it now strips the query before the asset check. The GitHub Pages 404.html redirect is unchanged (it already preserves the query).