Skip to content

test: FGP audit coverage (#1-#12) + hardening gap-documentation (#17)#18

Open
b3y0urs3lf wants to merge 1 commit into
mainfrom
fgp-audit-tests
Open

test: FGP audit coverage (#1-#12) + hardening gap-documentation (#17)#18
b3y0urs3lf wants to merge 1 commit into
mainfrom
fgp-audit-tests

Conversation

@b3y0urs3lf
Copy link
Copy Markdown
Contributor

Group A: regression guards for shipped PR #13/#11 fixes. Group B: characterization tests for the #17 hardening items — pass today by documenting the gap; flip per-finding when fixed.

Refs: #6 #8 #10 #12 #17

Group A: regression guards for shipped PR #13/#11 fixes.
Group B: characterization tests for the #17 hardening items —
pass today by documenting the gap; flip per-finding when fixed.

Refs: #6 #8 #10 #12 #17

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive suite of regression, integration, and observational tests to verify fixes and document existing gaps related to resource leaks, security vulnerabilities, and consensus logic. The tests cover BoltDB handle management, libp2p stream closure, CBOR amplification risks, and T1 timer re-arming. Feedback on the PR suggests improving the diagnostic output in the IPC client tests by logging the specific attempt on which the client recovers after a server restart.

Comment thread pow/ipc_client_test.go
Comment on lines +1013 to +1014
recovered = true
require.Equal(t, "ok", out)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better test output and consistency with Test_IPCClient_StalePoolAfterServerRestart_SelfHeals, consider adding a log line here to indicate on which attempt the client recovered and what the initial error was. This is helpful for debugging and understanding test runs where the stale-FD error occurs intermittently.

Suggested change
recovered = true
require.Equal(t, "ok", out)
recovered = true
t.Logf("recovered on attempt %d (firstErr=%v)", attempt, firstErr)
require.Equal(t, "ok", out)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant