Init improvements#7
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Sphere wallet initialization to improve DM backfill behavior and handle configured nametag changes by switching (or deriving) addresses within the same wallet, along with updating the Sphere SDK dependency needed for the new address APIs.
Changes:
- Pass a
dmSincetimestamp intoSphere.initto control DM history/backfill. - When configured nametag differs from the current wallet address nametag, switch to an existing address that owns the nametag or derive a new address and mint it there.
- Update unit tests to cover the new nametag-switching behavior and bump
@unicitylabs/sphere-sdkto0.6.8-dev.2.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/sphere.test.ts | Adds mocks/tests validating the new address switching + mint-on-new-address behavior. |
| src/sphere.ts | Adds dmSince init option and implements nametag-aware address switching/minting logic. |
| package.json | Pins Sphere SDK to a dev build to access new wallet/address APIs. |
| package-lock.json | Updates lockfile to reflect the new package version and dependency resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
116
to
120
| ...(existingMnemonic ? { mnemonic: existingMnemonic } : { autoGenerate: true }), | ||
| ...(cfg.nametag ? { nametag: cfg.nametag } : {}), | ||
| ...(groupChat ? { groupChat: groupChatRelays ? { relays: groupChatRelays } : true } : {}), | ||
| dmSince: Math.floor(Date.now() / 1000) - 86400, | ||
| }); |
Comment on lines
114
to
120
| const result = await Sphere.init({ | ||
| ...providers, | ||
| ...(existingMnemonic ? { mnemonic: existingMnemonic } : { autoGenerate: true }), | ||
| ...(cfg.nametag ? { nametag: cfg.nametag } : {}), | ||
| ...(groupChat ? { groupChat: groupChatRelays ? { relays: groupChatRelays } : true } : {}), | ||
| dmSince: Math.floor(Date.now() / 1000) - 86400, | ||
| }); |
| "@clack/prompts": "^0.10.0", | ||
| "@sinclair/typebox": "^0.34.48", | ||
| "@unicitylabs/sphere-sdk": "^0.6.7" | ||
| "@unicitylabs/sphere-sdk": "0.6.8-dev.2" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.