#122 Add network id to unicity id mint transaction

[martti007]

No description provided.

[gemini-code-assist]

Code Review

This pull request integrates networkId into UnicityIdMintTransaction and its certified variant, updating CBOR serialization, verification rules, and test suites. It also introduces private _brand properties to several transaction classes and refactors TypeScript configurations. The review feedback correctly identifies a backward-compatibility issue: adding networkId to the CBOR array changes its length from 6 to 7 without incrementing the transaction version, which will break deserialization of existing version 1 transactions. It is recommended to either bump the version or support both array lengths.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[MastaP]

Missing test for the new network-mismatch failure path

MintNetworkMatchesTrustBaseRule (in CertifiedUnicityIdMintTransactionVerificationRule) adds a FAIL branch, but the only test touched (tests/utils/TransitionFlow.ts) exercises the happy path with a matching trustBase.networkId. The VerificationStatus.FAIL branch is currently untested.

Given the project's emphasis on verification-rule coverage (cf. #115), please add a test that mints/verifies a unicity-id genesis with a mismatched networkId and asserts:

• the result is VerificationStatus.FAIL
• the message is Mint network does not match trust base.

Otherwise a regression in this check would go unnoticed.