Skip to content

Inflection-120 Update ICU version in versions.mk to 77.1 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrankYFTang merged 4 commits into from
May 30, 2025
Merged

Inflection-120 Update ICU version in versions.mk to 77.1 #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2f84e4
Update versions.mk
FrankYFTang May 29, 2025
285b9df
Update cmake-multi-platform.yml
FrankYFTang May 29, 2025
bce8d5d
Update cmake-multi-platform.yml
FrankYFTang May 29, 2025
0babfb9
Update cmake-multi-platform.yml
FrankYFTang May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/cmake-multi-platform.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,20 @@ jobs:
- name: Install ICU (Ubuntu/macos)
run: |
if [[ "${{ matrix.os }}" == "ubuntu-latest" ]]; then
sudo apt-get update && sudo apt-get install -y libicu-dev icu-devtools
echo "ICU_ROOT=/usr" >> $GITHUB_ENV
wget https://github.com/unicode-org/icu/releases/download/release-77-1/icu4c-77_1-Ubuntu22.04-x64.tgz
export TMP="/tmp/icu/"
# It may exist already - remove old stuff
mkdir -p $TMP
rm -rf $TMP/*

# Get the release and unpack.
cp icu4c-77_1-Ubuntu22.04-x64.tgz $TMP
pushd $TMP
tar xvfz *.tgz
rm *.tgz
ls -l icu/usr/local/lib
Copy link
Copy Markdown
Contributor

@nciric nciric Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need this line.

popd
echo "ICU_ROOT=/tmp/icu/icu/usr/local" >> $GITHUB_ENV
elif [[ "${{ matrix.os }}" == "macos-latest" ]]; then
brew list icu4c || brew install icu4c
echo "ICU_ROOT=$(brew --prefix icu4c)" >> $GITHUB_ENV
Expand Down
2 changes: 1 addition & 1 deletion inflection/cmake/versions.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
#
CATCH2_VERSION := 3.8.0
CF_VERSION := 5.10.1
ICU_VERSION_MINIMUM := 74.2
ICU_VERSION_MINIMUM := 77.1
MARISA_VERSION := 0.2.6