-
Notifications
You must be signed in to change notification settings - Fork 1.4k
add UC_CTL go bindings #2204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
K4ddate
wants to merge
26
commits into
unicorn-engine:dev
Choose a base branch
from
K4ddate:master
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add UC_CTL go bindings #2204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, sorry for late. The changes look good. Could you rebase it to dev? |
Hello @wtdcode, There you go, I changed the targeting branch to dev and upgraded the commit to match the updated dev branch. Hope this is better. |
…icorn-engine#2219) There has a hidden danger in g_hash_table_resize function: The g_hash_table_resize, it seems to resize the has table, and write the old value to the new hash table. It seems look for the empty items in the new_nodes, and if the new_nodes is not be cleared, it maybe naver found the empty items. So I added a line under the g_new0 function, and I think clearing new_nodes every time may improve the performance. Added a memset to clear the new_nodes to fix this problem. REF: intel/unicorn-for-efi#13 Signed-off-by: Chao Li <[email protected]> Signed-off-by: Dongyan Qian <[email protected]>
* Enable install for rust bindings * also search for lib64
…pple ARM64 wheel builds on PyPI. Fixes unicorn-engine#2033. (unicorn-engine#2227) * Fix `read_sprr_perm` for Apple real CPUs and GitHub Actions; enable Apple ARM64 wheel builds on PyPI. Fixes unicorn-engine#2033. * Guard `assert_executable` with `pthread_jit_write_protect_supported_np`
…size (unicorn-engine#2…" (unicorn-engine#2220) This reverts commit c8bc9eb.
* Python bindings: - Enable ABI wheel building - Rework the workflow in order to build ABI3 wheels for all python versions without any separations - Bump cibuildwheel to v2.23.3 * more memory * revert to previous value * Smaller tcg buffer size for this test * Migrate the action Reviewed-by: Antelox <[email protected]> * Add concurrency control * reduce because 32bit process may run-out-of virtual addresses * Revert "Add concurrency control" This reverts commit 79d76a9. * use macos-14 tempporarily --------- Co-authored-by: mio <[email protected]> Co-authored-by: ReenigneArcher <[email protected]>
You seem to mess up with the git history. If you are not familiar with it, I will cherry pick your commit afterwards with #2237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a straightforward pull request that adds UC_CTL bindings to the Go API. I needed these functions for a project I'm working on, so I decided to contribute them here.