Skip to content

tail: added tail to dynamic apps#88

Open
sl-81 wants to merge 2 commits into
unikraft:masterfrom
sl-81:tail
Open

tail: added tail to dynamic apps#88
sl-81 wants to merge 2 commits into
unikraft:masterfrom
sl-81:tail

Conversation

@sl-81
Copy link
Copy Markdown

@sl-81 sl-81 commented Sep 24, 2023

Signed-off-by: Shiyu Li [email protected]

Signed-off-by: Shiyu Li <[email protected]>

 Please enter the commit message for your changes. Lines starting
@razvand razvand self-requested a review September 25, 2023 16:38
@razvand razvand self-assigned this Sep 25, 2023
@razvand razvand added the enhancement New feature or request label Sep 25, 2023
Copy link
Copy Markdown
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits into one commit. Format the commit properly. Read this about writing a good commit message.

Comment thread tail/README.md
Comment on lines +1 to +4
# Python Interpreter

This is the Python interpreter, as an ELF file pulled out from a standard Linux filesystem (Ubuntu 22.04).
It's meant to be used with the binary-compatibility mode of Unikraft.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not Python, this is tail.

Comment thread tail/README.md


## Run tail on Linux

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add wording, something like: "To run tail on Linux, add a test file as an argument:"

Comment thread tail/README.md
Comment on lines +35 to +36


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Comment thread tail/README.md

```

## Run HTTP Server with Unikraft
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an HTTP server.

@razvand
Copy link
Copy Markdown
Contributor

razvand commented Sep 25, 2023

20 HP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: In Progress
Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants