Skip to content

Add UnZip static PIE build#71

Open
anindyasen wants to merge 1 commit intounikraft:masterfrom
anindyasen:unzip
Open

Add UnZip static PIE build#71
anindyasen wants to merge 1 commit intounikraft:masterfrom
anindyasen:unzip

Conversation

@anindyasen
Copy link
Copy Markdown

@anindyasen anindyasen commented Oct 10, 2022

#31

  1. Added zip application as a static-pie build
  2. A build.sh script is created to download, extract, patch and compile the application.
  3. rootfs, filesystem to store file in unikernel.
  4. Patch has the changes required in zip application to build it as static-pie.

StefanJum
StefanJum requested changes Oct 15, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you.
Please see the comments and also sign off your commit.

@anindyasen anindyasen requested a review from StefanJum October 19, 2022 19:53
StefanJum
StefanJum requested changes Oct 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few more comments.

@anindyasen anindyasen requested a review from StefanJum October 20, 2022 12:37
StefanJum
StefanJum requested changes Oct 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anindyasen, few more comments, I will approve the pr after you address them.

@anindyasen anindyasen requested a review from StefanJum October 21, 2022 09:45
@StefanJum
Copy link
Copy Markdown
Member

StefanJum commented Oct 21, 2022

All looks good now, but please remove the Co-authored-by: Jumarea Stefan <69107167+StefanJum@users.noreply.github.com> line from the commit message.

@anindyasen
Add UnZip static PIE build
6bbbe29 
Signed-off-by: anindya_sen <anindyasen007@gmail.com>
StefanJum
StefanJum approved these changes Oct 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thank you @anindyasen.

Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com

@anindyasen anindyasen mentioned this pull request Oct 21, 2022
Open
@razvand razvand linked an issue Oct 23, 2022 that may be closed by this pull request
Add UnZip static PIE build #31
Open
@razvand razvand added enhancement New feature or request kind/hackathon Hackathon challenge labels Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanJum StefanJum StefanJum approved these changes

Assignees

@razvand razvand

Labels

enhancement New feature or request kind/hackathon Hackathon challenge

Projects

(Binary) Application Compatibility
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add UnZip static PIE build

3 participants

@anindyasen @StefanJum @razvand