Open
Conversation
StefanJum
requested changes
Oct 15, 2022
Member
There was a problem hiding this comment.
Thank you for this @Giulia424, please see the comments.
Besides those, please also rename the directory from OpenSSL to openssl.
Signed-off-by: Giulia <[email protected]>
razvand
added
enhancement
StefanJum
requested changes
Oct 23, 2022
Member
StefanJum
left a comment
StefanJum
left a comment
There was a problem hiding this comment.
Looks good @Giulia424, just few more comments.
| @@ -0,0 +1,28 @@ | |||
| # Build OpenSSL as static PIE | |||
|
|
|||
| Script to build OpenSSL as a static PIE ELF binary. | |||
Member
There was a problem hiding this comment.
Suggested change
| Script to build OpenSSL as a static PIE ELF binary. | |
| Script to build OpenSSL as a static PIE ELF binary. |
| #!/bin/bash | ||
|
|
||
| SSL_URL="https://www.openssl.org/source/openssl-3.0.5.tar.gz" | ||
| rm -rf SSL-* |
Member
There was a problem hiding this comment.
Please add a cleanup step here.
The rm -rf SSL-* command does not do anything since there is nothing in the current directory to match that name.
It should remove the extracted source code, see nginx as an example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Giulia [email protected]