Add full Cleanroom library filter #124
Open
+15
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagyourtail
reviewed
Mar 13, 2025
| "org.lwjgl.lwjgl:lwjgl-platform:2.9.4-nightly-20150209", | ||
| "org.lwjgl.lwjgl:lwjgl:2.9.4-nightly-20150209", | ||
| "org.lwjgl.lwjgl:lwjgl_util:2.9.4-nightly-20150209" | ||
| ) |
There was a problem hiding this comment.
libraries that are just version changes (as in the package doesn't change, etc) don't need to be on this list; gradle will just use the most updated one.
therefore you can probably omit version numbers, except for lwjgl I guess. if you use vanillaExclude.any { library.name.startswith(it) } for the filter below
wagyourtail
reviewed
Mar 13, 2025
| return null | ||
| } | ||
| if (name.startsWith("org.lwjgl") && name.split(":").size > 3) { | ||
| if (!name.split(":")[2].endsWith(lwjglClassifier)) { |
There was a problem hiding this comment.
I don't think this'll ever be hit by the vanilla client json, because it uses library.natives and doesn't put them top level
There was a problem hiding this comment.
I wonder in which step it downloads natives though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since both old and new version of many libraries exist, I had to filter them by version