Skip to content

Conversation

@aryairani
Copy link
Contributor

Reverts #5801

@sellout sellout marked this pull request as ready for review July 11, 2025 20:19
@sellout sellout requested a review from a team as a code owner July 11, 2025 20:19
@sellout
Copy link
Contributor

sellout commented Jul 11, 2025

Ok, it’s funny that I wrote all the content of all these commits, and I’m marked as a reviewer, yet I can’t add @aryairani as a reviewer (because they opened the PR).

In any case, the transcripts keep failing on windows with those performance issues:

  2. count'test   ✗ performance too similar: 2.0

Annoying, but unrelated to this PR.

@aryairani
Copy link
Contributor Author

aryairani commented Jul 13, 2025

@sellout I can't review it and I can't approve it for merging either, because I opened it. So... let us know what you think of the current version, but it's got my moral approval.

@aryairani aryairani merged commit 4ee4199 into trunk Jul 13, 2025
47 checks passed
@aryairani aryairani deleted the revert-5801-revert-5798-check-integration-diffs branch July 13, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants