feat(loader): support validate with standard schema
#237
Conversation
Signed-off-by: ysknsid25 <[email protected]>
pi0
changed the title
validate with standard schema
Signed-off-by: ysknsid25 <[email protected]>
|
@ysknsid25 i will put more time on this PR before releasing in next minor releases. It is a big feature! |
| await expect( | ||
| loadConfig({ | ||
| configFile: "CUSTOM", | ||
| it("load fixture config with validate for zod - toThrow", async () => { |
There was a problem hiding this comment.
We have many new tests. As this feature is based on standard schema, validating against one of them is enough to make maintenance easier
package.json
Outdated
| "test:types": "tsc --noEmit" | ||
| }, | ||
| "dependencies": { | ||
| "@standard-schema/spec": "^1.0.0", |
There was a problem hiding this comment.
We can copy-paste types (as they suggest) to avoid extra dependency
src/types.ts
Outdated
| configFileRequired?: boolean; | ||
|
|
||
| schema?: S; | ||
| validate?: (schema: S, input: ResolvedConfig<T, MT>) => void; |
There was a problem hiding this comment.
Thinking how we could make it simpler. Like setting a schema could be enough (to also cover validate + schema transform)
There was a problem hiding this comment.
StandardSchema already has vendor and validate, so it looks like we can look at vendor and isolate the call to validate 👍
Give me more time 🙏
Signed-off-by: ysknsid25 <[email protected]>
define StandardSchema Signed-off-by: ysknsid25 <[email protected]>
define StandardSchema Signed-off-by: ysknsid25 <[email protected]>
define StandardSchema Signed-off-by: ysknsid25 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 76.92% 77.74% +0.82%
==========================================
Files 7 5 -2
Lines 806 346 -460
Branches 80 147 +67
==========================================
- Hits 620 269 -351
+ Misses 184 64 -120
- Partials 2 13 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ysknsid25
force-pushed
the
feature/impl-standard-schema
branch
2 times, most recently
from
9b10eda to
cfdf5fa
Compare
implement validate and transform Signed-off-by: ysknsid25 <[email protected]>
ysknsid25
force-pushed
the
feature/impl-standard-schema
branch
from
cfdf5fa to
f1758fa
Compare
|
Hello @pi0 . I have a consultation 🙇 Can you make feature branch for this issue? In this branch, write test for Zod and valibot and marge to new feature branch. remaning test code will be written another each branch. How about? 👀 |
2 participants
attempts to resolve #228
Test Targets
This is because they are clearly stated to conform to Standard Schema.