Skip to content

fix(plugin): raise minimum unraid os version to 6.12.15#1649

Merged
elibosley merged 1 commit into
mainfrom
fix/min-version
Sep 3, 2025
Merged

fix(plugin): raise minimum unraid os version to 6.12.15#1649
elibosley merged 1 commit into
mainfrom
fix/min-version

Conversation

@pujitm

@pujitm pujitm commented Sep 3, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Requirements
    • Minimum supported Unraid version increased to 6.12.15.
  • Chores
    • Updated runtime version checks to enforce 6.12.15+ and exclude incompatible pre-releases.
    • Refreshed user-facing messages to reference the new minimum version.
  • Bug Fixes
    • Exits with a non-zero status on unsupported versions to correctly signal failure to scripts and automations.

@pujitm pujitm requested a review from elibosley September 3, 2025 19:06
@coderabbitai

coderabbitai Bot commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Updates the Unraid version requirement to 6.12.15 in the plugin manifest and runtime checks, adjusts user-facing messages accordingly, and changes the unsupported-version exit code from 0 to 1. A regex guard continues to exclude 6.12.0- pre-releases.

Changes

Cohort / File(s) Summary
Version requirement updates
plugin/plugins/dynamix.unraid.net.plg
- Manifest PLUGIN min changed: 6.9.0-rc1 → 6.12.15
- Runtime check threshold raised: 6.12.0/6.12.0+ → 6.12.15+
- Regex guard still excludes 6.12.0- prereleases
- Messages updated to reference 6.12.15
- Unsupported versions now exit with code 1 (was 0)

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as User
  participant P as Plugin (dynamix.unraid.net.plg)
  participant S as Unraid System

  U->>P: Install/Run plugin
  P->>S: Query Unraid version
  S-->>P: Version string

  rect rgb(238,245,255)
  note right of P: Version gate updated to 6.12.15+<br/>Regex excludes 6.12.0- prereleases
  alt Version < 6.12.15 or matches 6.12.0-
    P-->>U: Display message referencing 6.12.15
    P->>U: Exit with code 1
  else Version ≥ 6.12.15
    P-->>U: Proceed with normal plugin execution
  end
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my paws on version hills, hooray!
From rc past to 6.12.15, we hop today.
If too low, I squeak and exit one—no fudge!
Regex nibbles pre’s away; I will not budge.
Carrots aligned, the plugin’s runway’s clear—ok, play! 🥕✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7c3aee8 and 2c6da55.

📒 Files selected for processing (1)
  • plugin/plugins/dynamix.unraid.net.plg (2 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/min-version

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov

codecov Bot commented Sep 3, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.85%. Comparing base (7c3aee8) to head (2c6da55).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1649   +/-   ##
=======================================
  Coverage   53.85%   53.85%           
=======================================
  Files         797      797           
  Lines       44310    44310           
  Branches     4493     4493           
=======================================
  Hits        23864    23864           
  Misses      20410    20410           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1649/dynamix.unraid.net.plg

@elibosley elibosley merged commit bc15bd3 into main Sep 3, 2025
13 of 14 checks passed
@elibosley elibosley deleted the fix/min-version branch September 3, 2025 19:20
elibosley pushed a commit that referenced this pull request Sep 3, 2025
🤖 I have created a release *beep* *boop*
---


## [4.18.2](v4.18.1...v4.18.2)
(2025-09-03)


### Bug Fixes

* add missing CPU guest metrics to CPU responses
([#1644](#1644))
([99dbad5](99dbad5))
* **plugin:** raise minimum unraid os version to 6.12.15
([#1649](#1649))
([bc15bd3](bc15bd3))
* update GitHub Actions token for workflow trigger
([4d8588b](4d8588b))
* update OIDC URL validation and add tests
([#1646](#1646))
([c7c3bb5](c7c3bb5))
* use shared bg & border color for styled toasts
([#1647](#1647))
([7c3aee8](7c3aee8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants