Skip to content

Fix: FF disabled menu item color#2426

Merged
limetech merged 2 commits into
unraid:masterfrom
Squidly271:patch-8
Oct 16, 2025
Merged

Fix: FF disabled menu item color#2426
limetech merged 2 commits into
unraid:masterfrom
Squidly271:patch-8

Conversation

@Squidly271

@Squidly271 Squidly271 commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Style
    • Improved styling for disabled dropdown options, adding consistent disabled text color globally and within the sidebar theme to enhance clarity and visual consistency across the interface.

@coderabbitai

coderabbitai Bot commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Two CSS rules were added to emhttp/plugins/dynamix/styles/default-base.css: a global select option:disabled rule and a duplicate nested select option:disabled rule inside the Theme--sidebar override, both setting disabled options' text color to var(--disabled-text-color).

Changes

Cohort / File(s) Change Summary
Select option disabled styling
emhttp/plugins/dynamix/styles/default-base.css
Added two select option:disabled { color: var(--disabled-text-color); } rules — one global and one inside the Theme--sidebar override — to apply the disabled text color to disabled select options.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰
A little rule hopped into place,
Disabled options find their grace,
With softer hue and gentle tone,
The UI feels less all alone,
I nibble bugs — this change is ace! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly describes the primary change, namely fixing the disabled menu item color in Firefox, which directly corresponds to the newly added CSS rules targeting disabled select options.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1940f8b and 66528c2.

📒 Files selected for processing (1)
  • emhttp/plugins/dynamix/styles/default-base.css (2 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Oct 16, 2025

Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2025.10.16.1346
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2426/webgui-pr-2426.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix/styles/default-base.css

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2426, or run:

plugin remove webgui-pr-2426

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce4653a and 1940f8b.

📒 Files selected for processing (1)
  • emhttp/plugins/dynamix/styles/default-base.css (1 hunks)

Comment thread emhttp/plugins/dynamix/styles/default-base.css
@ljm42 ljm42 added the 7.2 label Oct 16, 2025
@limetech limetech merged commit 5dbe538 into unraid:master Oct 16, 2025
2 checks passed
@Squidly271 Squidly271 deleted the patch-8 branch November 5, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants