fix: Sort and widen VM network source dropdown#2656
Conversation
Sort libvirt network source options using natural, case-insensitive order while preserving default as the first libvirt option. Widen the VM Network Source select by giving it a scoped network_source class that fills the existing VM form width wrapper.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis PR improves the presentation and behavior of network source dropdowns in the VM manager plugin. It sorts the libvirt network list alphabetically in the backend, adds CSS styling to display dropdowns at full width, and applies that styling class to both statically rendered and dynamically generated network selection elements. ChangesNetwork Source Dropdown UX
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔧 PR Test Plugin AvailableA test plugin has been generated for this PR that includes the modified files. Version: 📥 Installation Instructions:Install via Unraid Web UI:
Alternative: Direct Download
|
Summary
defaultfirstTesting
git diff --checkgit diff --cached --checkphp -l emhttp/plugins/dynamix.vm.manager/include/libvirt_helpers.phpphp -l emhttp/plugins/dynamix.vm.manager/templates/Custom.form.php/usr/local/emhttpSummary by CodeRabbit
Release Notes
Style
Bug Fixes