Skip to content

Revert "feat(header): gate consolidated <unraid-header> on Unraid 7.3+"#2702

Merged
limetech merged 1 commit into
masterfrom
revert-2689-feat/consolidated-header
Jul 22, 2026
Merged

Revert "feat(header): gate consolidated <unraid-header> on Unraid 7.3+"#2702
limetech merged 1 commit into
masterfrom
revert-2689-feat/consolidated-header

Conversation

@limetech

@limetech limetech commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Reverts #2689

Summary by CodeRabbit

  • UI Changes
    • Removed the configurable header logo style setting from Display Settings.
    • Simplified the application header layout for a more consistent presentation.
    • Removed legacy styling specific to the previous consolidated header design.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c0a536f7-b33f-4a5c-890c-ee0f1f4cc593

📥 Commits

Reviewing files that changed from the base of the PR and between b6d4e0d and 6f4f2fd.

📒 Files selected for processing (4)
  • emhttp/plugins/dynamix/DisplaySettings.page
  • emhttp/plugins/dynamix/default.cfg
  • emhttp/plugins/dynamix/include/DefaultPageLayout/Header.php
  • emhttp/plugins/dynamix/styles/default-base.css
💤 Files with no reviewable changes (2)
  • emhttp/plugins/dynamix/default.cfg
  • emhttp/plugins/dynamix/DisplaySettings.page

Walkthrough

The header logo configuration is removed from the display settings and defaults. Header rendering no longer branches by Unraid version, and consolidated-header-specific CSS and inline setup are removed.

Changes

Header cleanup

Layer / File(s) Summary
Remove header logo configuration
emhttp/plugins/dynamix/DisplaySettings.page, emhttp/plugins/dynamix/default.cfg
Removes the header logo selector from display settings and deletes its default configuration entry.
Simplify header rendering and styles
emhttp/plugins/dynamix/include/DefaultPageLayout/Header.php, emhttp/plugins/dynamix/styles/default-base.css
Renders the simplified header structure unconditionally and removes consolidated-header-specific PHP and CSS behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • unraid/webgui#2701: Modifies overlapping consolidated header and logo markup in Header.php.

Suggested reviewers: elibosley

Poem

I’m a rabbit with a tidy header to show,
No logo dropdown, no branching below.
The styles shed their padding and shine,
While the version tag stands in line.
Hop, hop—clean code grows!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately states that the PR reverts the consolidated gating change and matches the main theme of the diff.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-2689-feat/consolidated-header

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.07.22.1917
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2702/webgui-pr-2702.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix/DisplaySettings.page
emhttp/plugins/dynamix/default.cfg
emhttp/plugins/dynamix/include/DefaultPageLayout/Header.php
emhttp/plugins/dynamix/styles/default-base.css

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2702, or run:

plugin remove webgui-pr-2702

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@limetech
limetech merged commit 6d8c2cd into master Jul 22, 2026
5 checks passed
@limetech
limetech deleted the revert-2689-feat/consolidated-header branch July 22, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants