edit save.py to fix gguf saving breaks. #1649
Open
+38
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wait Windows machines uses ".exe" - Linux machines do not - would you be able to add a check for linux and windows platforms? I can do it as well! Thanks for the PR! |
Yea, i can add this, give me more time |
There was a problem hiding this comment.
check please this version
its working now on Windows 11 x64 via WSL Ubuntu in Cursor IDE. @danielhanchen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this, i found solution for gguf saving errors if user working on local machine (not Collab where everything with this issue is fine) #748 (comment)
GGUF saving breaks fixed. just added .exe format to codelines in save.py
WSL ubuntu in windows 11.
@danielhanchen
@shimmyshimmer