This repository was archived by the owner on Nov 25, 2024. It is now read-only.
Allow env var to always publish #253
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Actually do the
# TODO(hasheddan): remove master and support overridingfrom the makefile.This removes
masterfrom the list of branch names that get published, and adds support for an env var, tentatively namedDO_PUBLISH, which will cause the build module to publish regardless of branch.If anyone has a better suggestion for the env var name I'm happy to change it.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested