Add support for timestamp on date assert #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/asserts/date-assert_test.js
Outdated
| describe('DateAssert', () => { | ||
| it('should throw an error if the input value is not a string or a date', () => { | ||
| const choices = [[], {}, 123]; | ||
| describe.only('DateAssert', () => { |
|
Can you apply the same changes to NullOrDateAssert, DateDiffGreaterThanAssert, DateDiffLessThanAssert? |
src/asserts/date-assert.js
Outdated
| if (typeof value !== 'string' && Object.prototype.toString.call(value) !== '[object Date]') { | ||
| throw new Violation(this, value, { value: 'must_be_a_date_or_a_string' }); | ||
| if (typeof value === 'string') { | ||
| if (isNaN(Date.parse(value)) === true) { |
There was a problem hiding this comment.
if (isNaN(Date.parse(value))) {
ruimarinho
force-pushed
the
enhancement/add-support-for-timestamp-on-date-assert
branch
from
69b8552 to
3c247f3
Compare
|
Added a few more tests and fixed comments. Can you fix the other asserts before merging this in? |
madeiras
force-pushed
the
enhancement/add-support-for-timestamp-on-date-assert
branch
from
3c247f3 to
ddf9ab1
Compare
franciscocardoso
force-pushed
the
enhancement/add-support-for-timestamp-on-date-assert
branch
from
c0cc9a6 to
1cc468e
Compare
| Tests if the value is not an empty (empty object, empty array, empty string, etc). | ||
|
|
||
| ### NullOrDate | ||
| Tests if the value is a `null` or `date`. |
There was a problem hiding this comment.
...or a number ? (timestamp)
There was a problem hiding this comment.
If so we need to update here as well.
madeiras
force-pushed
the
enhancement/add-support-for-timestamp-on-date-assert
branch
from
1cc468e to
7d7dfad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93.
Some options were explored such as using a RegExp or forcing
momentas a requirement. The proposed solution (the simplest) proved to be the most reliable though.