-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add map typed flags #15
Conversation
Signed-off-by: Artemiy Ryabinkov <[email protected]>
Signed-off-by: Artemiy Ryabinkov <[email protected]>
Signed-off-by: Artemiy Ryabinkov <[email protected]>
Signed-off-by: Artemiy Ryabinkov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 99.29% 99.95% +0.65%
==========================================
Files 10 10
Lines 1424 8042 +6618
==========================================
+ Hits 1414 8038 +6624
+ Misses 7 2 -5
+ Partials 3 2 -1
Continue to review full report at Codecov.
|
cmd/genvalues/main.go
Outdated
func parseGeneratedMap(value interface{}) Value { | ||
switch value.(type) { | ||
{{range .Values}}{{ if not .NoMap }}\nn | ||
{{ $value := . }}{{range $mapKeyTypes}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add \nn here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
Signed-off-by: Artemiy Ryabinkov <[email protected]>
Signed-off-by: Artemiy Ryabinkov <[email protected]>
Signed-off-by: Artemiy Ryabinkov <[email protected]>
Signed-off-by: Artemiy Ryabinkov <[email protected]>
Signed-off-by: Artemiy Ryabinkov <[email protected]>
Signed-off-by: Artemiy Ryabinkov <[email protected]>
Signed-off-by: Artemiy Ryabinkov <[email protected]>
Thank you! |
Issue #7
This PR add availability of map typed flags usage. Map keys can be string or kind of integer, and values can be any types available as flags by this library.
Example:
TODO: