Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization docker file #21

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Optimization docker file #21

merged 4 commits into from
Jan 31, 2025

Conversation

agibalovsa
Copy link

Fix error urandom.
Fix error documentation.
Optimization docker file.

Fix error documentation.
Optimization docker file.
@urpylka
Copy link
Owner

urpylka commented Jan 28, 2025

Hi, the test revealed an issue: ADD does not support variables in Dockerfile.

Please replace the line in your PR:

ADD https://raw.githubusercontent.com/aptly-dev/aptly/v${VER_APTLY}/completion.d/aptly /usr/share/bash-completion/completions/aptly

with:

RUN curl -o /usr/share/bash-completion/completions/aptly \
    https://raw.githubusercontent.com/aptly-dev/aptly/v${VER_APTLY}/completion.d/aptly

Let me know once you've updated it.

@urpylka
Copy link
Owner

urpylka commented Jan 30, 2025

Have you heard that Bash completion for Aptly has been added to the Debian package? (source: #20)

@agibalovsa
Copy link
Author

I checked it. Indeed, this line "curl -sLo /usr/share/bash-completion/completions/aptly https://raw.githubusercontent.com/aptly-dev/aptly/v${VER_APTLY}/completion.d/aptly;" is undue.
image
Should I delete it?

@urpylka
Copy link
Owner

urpylka commented Jan 31, 2025

I suppose so. How did you test it? I see a terminal in the screenshot, but as far as I understand, it is not a subcommand of Aptly.

To test it, you need to connect to the container, type 'aptly', and press the TAB key a few times. This should display the available subcommands of Aptly.

@agibalovsa
Copy link
Author

agibalovsa commented Jan 31, 2025

I suppose so. How did you test it? I see a terminal in the screenshot, but as far as I understand, it is not a subcommand of Aptly.

it's files of directory "/usr/share/bash-completion/completions". And file "aptly" is there.

To test it, you need to connect to the container, type 'aptly', and press the TAB key a few times. This should display the available subcommands of Aptly.

Yes, i checked it. It's OK.

@urpylka urpylka merged commit ed88a2d into urpylka:master Jan 31, 2025
2 checks passed
@urpylka
Copy link
Owner

urpylka commented Jan 31, 2025

Thanks for the PR

@agibalovsa
Copy link
Author

Thank you for PR aproval :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants