chore: Strengthen contribution rules and triage infra#839
Open
ananos wants to merge 3 commits into
Open
Conversation
Following an increase of drive-by issues and PRs, mostly around mentorship program cycles, we should make the contribution rules more explicit: - Bug reports must come with actual logs and command output. Issues that only describe code the reporter has read get the needs-repro label and are closed if the information is not provided. - PRs are expected to reference an issue that a maintainer has labeled as accepted, except for trivial fixes. - Please do not @-mention maintainers right after opening an issue. - Mentorship-related work only counts on issues explicitly marked with the mentorship label. Signed-off-by: Anastassios Nanos <ananos@nubificus.co.uk>
At the moment the stale bot marks and closes issues that maintainers have already confirmed, while unverified reports sit in the queue unaffected. Exempt the accepted, confirmed and mentorship labels for issues, and PRs that a maintainer has engaged with (ok-to-test, takeover, accepted). Unlabeled items, eg. reports pending the needs-repro information, keep the current 60+15 day cycle. Signed-off-by: Anastassios Nanos <ananos@nubificus.co.uk>
The build and unit-test jobs run with a job-level continue-on-error, so a PR shows a green check even when it does not compile or its tests fail. For instance, the branch of an open PR currently fails to build, while its checks appear green. Remove the flag so that CI failures are visible in the PR checks. The build-latest and upload_s3 workflows are left untouched, as they do not gate PRs. Fixes: #729 Signed-off-by: Anastassios Nanos <ananos@nubificus.co.uk>
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following an increase of drive-by issues and PRs, mostly around mentorship
program cycles, this PR makes our contribution rules more explicit and fixes
two infra quirks that make triaging harder than it should be:
docs/developer-guide/contribute.md: bug reports must include the actuallogs and output of the failing commands -- issues that only describe code the
reporter has read get a
needs-reprolabel and are closed if the info is notprovided. PRs are expected to reference an issue a maintainer has labeled as
accepted(trivial fixes exempt). We also kindly ask people not to@-mention maintainers right after opening an issue, and clarify that
mentorship-related work only counts on issues explicitly marked with a
mentorshiplabel.stale.yml: the stale bot currently nags issues that maintainers havealready confirmed, while unverified reports keep sitting in the queue. Exempt
the
accepted,confirmedandmentorshiplabels for issues and theok-to-test/takeover/acceptedlabels for PRs.build.yml/unit_test.yml: remove the job-levelcontinue-on-error, sothat a PR that does not compile or fails its unit tests shows a red check
instead of a green one.
build-latest.ymlandupload_s3.ymlare leftuntouched, as they do not gate PRs.
Note: for the new labels to be effective, we need to create
accepted,needs-repro,confirmedandmentorshipin the repo. Will do that as soonas this gets merged.
Related issues
How was this tested?
Docs and workflow-only changes, no code is touched. The markdown was reviewed
rendered locally and the workflow changes are a label-list extension and two
line deletions. CI on this PR exercises the modified build/unit-test
workflows directly.
LLM usage
Claude (Fable 5, via Claude Code). All content reviewed and edited by me.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).