Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize cargo metadata command execution #2471

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xsenty
Copy link

@0xsenty 0xsenty commented Apr 3, 2025

Description

cargo metadata command was being executed twice with the same parameters, which resulted in redundant operations and unnecessary load, to address this, I've modified the script to run the cargo metadata command just once, saving the result into a variable and reusing it for further processing.

this should improve the script's efficiency and reduce unnecessary computations.

Checklist before requesting a review

  • I have added an entry to CHANGELOG.md
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@0xsenty 0xsenty requested review from cmichi and ascjones as code owners April 3, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant