Rebrand BWS -> BWLK and retarget the CCA launch to Ethereum mainnet - #2
Merged
Conversation
…nnet Token contracts (Sherlock-audited) change by strict identifier rename only: reverse-applying bwlk->bws to BWLK.sol, BwlkMigration.sol, UnsoldBurner.sol and their interfaces reproduces the audited sources byte-for-byte. No error or event names contained the ticker, so no selectors or topics change beyond the intentionally renamed public getters. Launch retarget: EthereumConfig (chain 1, mainnet WETH/v4 trio, the v3.1.0 LiquidityLauncher/LBPStrategy and its initializerFactory - all verified live on-chain, struct layouts field-identical to v3.1.0 sources). New supply split: 2,711,068 migration / 157,500 CCA sale / 157,500 LP seed / 123,932 LP incentives. No graduation threshold: default 0, launch must attest via CCA_ZERO_GRADUATION_ATTESTED. Floor and tick are required envs until announced. The ArbSys simulation shim is gone - mainnet's CCA clock is plain block.number, so vm.roll drives the fork tests and broadcast simulation needs no workarounds. BMX source address is a required env pending the migration re-scope. Fork tests retarget to mainnet (launch pipeline, unsold burner, deploy gate - all pass against the live v3.1.0 deployment); the Base-fork migration test passes unchanged. Full non-fork suite: 1325 tests.
PR SummaryHigh Risk Overview Supply and launch parameters change: CCA bucket is 315,000 BWLK (157,500 auction + 157,500 LP seed) vs the old 438,932 BWS split; migration pool stays 2,711,068 with a new 123,932 LP incentives bucket in config. CCA defaults drop Arbitrum floor/tick/graduation math—no graduation threshold (default 0, requires Ops wiring: Reviewed by Cursor Bugbot for commit 8325ec6. Configure here. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR retargets token, migration, deployment, CCA launch, governance, revenue bridging, burner, and validation flows from Arbitrum BWS to Ethereum BWLK. It adds Ethereum constants, canonical DEX and lane configuration, updates runbooks, and migrates unit, integration, invariant, and fork coverage. ChangesBWLK Ethereum migration
Estimated code review effort: 5 (Critical) | ~120 minutes Sequence Diagram(s)sequenceDiagram
participant DeployBWLK
participant BwlkMigration
participant DeployBwlkGovernance
participant LaunchBwlkCca
participant AssertBwlkDeploy
DeployBWLK->>BwlkMigration: deploy and fund migration pool
DeployBwlkGovernance->>BwlkMigration: wire BWLK trackers and governance
LaunchBwlkCca->>BwlkMigration: configure migration parameters
AssertBwlkDeploy->>LaunchBwlkCca: validate BWLK launch wiring
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Re-home Ethereum revenue before wiring the voter
When using this Ethereum deployment path, the voter only receives revenue if the chain's BoardwalkFeeCollector has governanceVault set to it (src/core/BoardwalkFeeCollector.sol:159-166). The unchanged revenue mesh still treats chain id 1 as a source lane to Base and explicitly tells ops to repoint treasury to the bridger while keeping governanceVault == address(0) (script/06_DeployRevenueBridging.s.sol:10-28, script/CrossChainConfig.sol:73-79). If both runbooks are followed after this retarget, Ethereum revenue is forwarded down the Base-bridger path and this BWLK voter never receives its 70% governance budget; the Ethereum lane/runbook needs to be removed or re-homed with the voter as the vault.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
test/fork/UnsoldBurnerFork.t.sol (1)
51-54: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winSource the fork-test addresses from
script/bwlk/EthereumConfig.sol.test/fork/UnsoldBurnerFork.t.sol:52-54duplicates values that already live inEthereumConfig(ETH_CCA_FACTORY,ETH_LIQUIDITY_LAUNCHER,ETH_LBP_STRATEGY), so this can drift for no benefit.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/fork/UnsoldBurnerFork.t.sol` around lines 51 - 54, Replace the duplicated address literals in UnsoldBurnerFork’s CCA_FACTORY, LIQUIDITY_LAUNCHER, and LBP_STRATEGY constants with the corresponding ETH_CCA_FACTORY, ETH_LIQUIDITY_LAUNCHER, and ETH_LBP_STRATEGY values from EthereumConfig. Preserve the existing test references while sourcing these addresses from the shared configuration.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@script/bwlk/04_AssertBwlkDeploy.s.sol`:
- Around line 229-235: The supply-only validation around
IERC20Meta(cfg.bwlk).totalSupply in script/bwlk/04_AssertBwlkDeploy.s.sol lines
229-235 must also verify cfg.bwlk against an independently attested canonical
deployment address or deployment-specific code hash. Apply the same canonical
identity check in script/bwlk/05_DeployUnsoldBurner.s.sol lines 25-29 before
embedding the token in UnsoldBurner; retain the existing supply validation.
- Around line 187-189: Update the warning in _assertCcaWiring for an unset
cfg.lpLocker to state that governance one-shots A-5 through A-9 are not checked,
so every skipped locker assertion is reported.
In `@script/bwlk/06_LaunchBwlkCca.s.sol`:
- Around line 410-413: Complete the Ethereum retarget across all listed
documentation sites: in script/bwlk/06_LaunchBwlkCca.s.sol lines 410-413, use
the Ethereum mainnet RPC variable instead of $ARB_RPC; update src/token/BWLK.sol
lines 6-8 to identify BWLK as the Ethereum mainnet token; revise the Arbitrum
deployment references in script/bwlk/02_DeployBwlkGovernance.s.sol lines 10-14;
describe the Ethereum BMX-to-BWLK migrator in
script/bwlk/03_DeployBwlkMigration.s.sol lines 10-13; update the Ethereum
go-live gate wording in script/bwlk/04_AssertBwlkDeploy.s.sol lines 69-72; and
replace “brought to Arbitrum” with Ethereum migration wording in lines 91-93.
In `@src/interfaces/ILiquidityLauncher.sol`:
- Line 5: Correct the malformed NatSpec sentence in the liquidity launcher
interface comment by rewriting it as a grammatically valid description, such as
“The Uniswap LiquidityLauncher calls made by the BWLK CCA launch script.”
In `@test/fork/BwlkEthereumDeployFork.t.sol`:
- Around line 67-70: Track whether BMX is a valid deployed token before
replacing it with the MockERC20 fallback, then update
testFork_BmxIsNonFeeOnTransfer to skip when the real token is unavailable. Keep
the mock fallback for other tests, but ensure this proof cannot pass against
MockERC20.
---
Nitpick comments:
In `@test/fork/UnsoldBurnerFork.t.sol`:
- Around line 51-54: Replace the duplicated address literals in
UnsoldBurnerFork’s CCA_FACTORY, LIQUIDITY_LAUNCHER, and LBP_STRATEGY constants
with the corresponding ETH_CCA_FACTORY, ETH_LIQUIDITY_LAUNCHER, and
ETH_LBP_STRATEGY values from EthereumConfig. Preserve the existing test
references while sourcing these addresses from the shared configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 98bb80d8-6e5c-4394-bd59-c587430b2add
📒 Files selected for processing (35)
README.mdscript/bwlk/01_DeployBWLK.s.solscript/bwlk/02_DeployBwlkGovernance.s.solscript/bwlk/03_DeployBwlkMigration.s.solscript/bwlk/04_AssertBwlkDeploy.s.solscript/bwlk/05_DeployUnsoldBurner.s.solscript/bwlk/06_LaunchBwlkCca.s.solscript/bwlk/EthereumConfig.solscript/bws/01_DeployBWS.s.solscript/bws/ArbitrumConfig.solsrc/interfaces/IBWLK.solsrc/interfaces/IBwlkMigration.solsrc/interfaces/ICcaAuctionFactory.solsrc/interfaces/ILBPStrategy.solsrc/interfaces/ILiquidityLauncher.solsrc/interfaces/IMintable.solsrc/interfaces/IPermit2.solsrc/interfaces/IUnsoldBurner.solsrc/token/BWLK.solsrc/token/BwlkMigration.solsrc/token/UnsoldBurner.soltest/bwlk/LaunchCcaMocks.soltest/bwlk/MockMorphexStaking.soltest/bwlk/UnsoldBurnerMocks.soltest/fork/BwlkEthereumDeployFork.t.soltest/fork/BwlkMigrationFork.t.soltest/fork/LaunchBwlkCcaFork.t.soltest/fork/UnsoldBurnerFork.t.soltest/unit/BWLK.t.soltest/unit/BWS.t.soltest/unit/BwlkDeployAssertion.t.soltest/unit/BwlkMigration.t.soltest/unit/BwlkMigrationMerkle.t.soltest/unit/LaunchBwlkCca.t.soltest/unit/UnsoldBurner.t.sol
💤 Files with no reviewable changes (3)
- test/unit/BWS.t.sol
- script/bws/01_DeployBWS.s.sol
- script/bws/ArbitrumConfig.sol
- Gate warning now reports the full skipped range (A-5..A-9) - Finish the Ethereum retarget in script docs: launch runbook prints $ETH_RPC; 02/03/04 titles and comments no longer say Arbitrum - ILiquidityLauncher notice reworded for clarity - The fork-test BMX non-fee-on-transfer proof skips when the real token address is unavailable instead of passing against the mock - UnsoldBurnerFork sources the CCA addresses from EthereumConfig - Revenue-mesh script: the Ethereum source lane is explicitly retired for the BWLK era (Ethereum is the governance home; bridging its revenue to Base would starve the voter's 70% budget) The audited src/token sources stay strictly rename-only (their chain wording updates with the migration re-scope docs pass) so the byte-for-byte reverse-rename diff vs the Sherlock-audited originals keeps holding.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@script/06_DeployRevenueBridging.s.sol`:
- Around line 29-34: Update run() to reject CHAIN_ETHEREUM before
vm.startBroadcast and before any _deployLifiBridger invocation, preserving
deployment for other non-Base chains. Add a regression test that exercises the
Ethereum path and asserts the expected revert.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ad4da8b5-dbac-47b8-a320-71fe7b256aa7
📒 Files selected for processing (8)
script/06_DeployRevenueBridging.s.solscript/bwlk/02_DeployBwlkGovernance.s.solscript/bwlk/03_DeployBwlkMigration.s.solscript/bwlk/04_AssertBwlkDeploy.s.solscript/bwlk/06_LaunchBwlkCca.s.solsrc/interfaces/ILiquidityLauncher.soltest/fork/BwlkEthereumDeployFork.t.soltest/fork/UnsoldBurnerFork.t.sol
🚧 Files skipped from review as they are similar to previous changes (7)
- src/interfaces/ILiquidityLauncher.sol
- script/bwlk/02_DeployBwlkGovernance.s.sol
- script/bwlk/03_DeployBwlkMigration.s.sol
- test/fork/UnsoldBurnerFork.t.sol
- script/bwlk/06_LaunchBwlkCca.s.sol
- test/fork/BwlkEthereumDeployFork.t.sol
- script/bwlk/04_AssertBwlkDeploy.s.sol
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c5c64e14b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The BWLK carve-out was documentation-only: run() on chainId 1 would still deploy a Base-pinned RevenueBridger, and a treasury repoint to it would ship the governance home's own revenue to Base past the voter. Guard first, before any env read, plus a regression test.
Floor = the announced $0.30 per BWLK in ETH terms at the launch-day Chainlink read ($1,870.97/ETH) = 0.0001603446 ETH, tick-aligned at floor = 100 ticks. Script 06 reads both via envOr again; the pin test covers the literals and the CCA constructor bounds for the 157,500 supply.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49741f0974
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…wap v2, Ethereum revenue hub Rebrand BMX -> BWLK across all core contracts, scripts, and tests (migration contracts keep BMX for the legacy token); GOVERNANCE_BPS 7000 -> 9000 (10/90 treasury/governance split) and 5 WETH graduation defaults. Retarget the chain set to Ethereum, Base, Arbitrum, and Robinhood Chain (4663): - Drop the forked DEX; deploy against canonical Uniswap v2 per chain (script/DexConfig.sol, on-chain-verified addresses), minimal IUniswapV2Pair for PresaleManager's seed mint. - One standardized fee schedule: issuer 35 / boardwalk 35 / incentive 15 / referrer 5 / integrator 10 = 95 bps tax (+30 bps v2 pair fee = 1.25%). Five 2-bps integrator slots; DefiLlama Research pending via DEFILLAMA_RESEARCH_ADDRESS env (deploy fails loudly if unset). - Re-home the revenue mesh to Ethereum: BaseRevenueSwapper -> EthereumRevenueSwapper, bridgeToEthereum with destinationChainId pinned to 1, all lanes pure Across V4 WETH; lane config reverts for chainId 1. - NFT bridge: 05_AddLockboxPeer drives the typed SET_PEER timelock for new spokes (Robinhood mirror); CCIPConfig gains the Robinhood selector/router. - Remove Fraxtal/Katana/Ink everywhere; delete the superseded 03_DeployGovernance script (script/bwlk/02 is the governance deploy surface). - Rewrite README/SPEC/AGENTS for the BWLK era; add DeployConfigs.t.sol pinning the production schedule and per-chain address literals. 1336 non-fork tests pass; revenue lanes fork-tested against the live Base, Arbitrum, and Robinhood LiFi diamonds.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c50dc69e6b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 7
🧹 Nitpick comments (1)
script/02_DeployFactory.s.sol (1)
38-49: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winInconsistent keeper env-var name across deploy scripts. Both scripts were updated in this PR to require a keeper address, but they now use different env-var names for the same concept, unlike every other renamed var (
BWLK_ADDRESS,DEX_FACTORY,DEX_ROUTER,TREASURY) which stays consistent between them.
script/02_DeployFactory.s.sol#L38-L49: usesvm.envAddress("KEEPER"), matchingscript/bwlk/02_DeployBwlkGovernance.s.sol's convention.script/test/01_TestDeploy.s.sol#L28-L55: usesvm.envAddress("KEEPER_ADDRESS")instead; align it to"KEEPER"(or vice versa) so operators don't set the wrong env var for one of the two scripts.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@script/02_DeployFactory.s.sol` around lines 38 - 49, Standardize the keeper environment-variable name across both deployment scripts: keep script/02_DeployFactory.s.sol lines 38-49 using KEEPER, and update script/test/01_TestDeploy.s.sol lines 28-55 to read KEEPER instead of KEEPER_ADDRESS. Ensure both scripts use the same variable for the keeper address.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@script/04_DeployNFTBridge.s.sol`:
- Around line 35-37: The ownership timeline comment in the deployment runbook
must account for the `OWNER` configuration. Update the guidance near the NFT
bridge deployment and subsequent multisig transfer to either require `OWNER` to
equal the deployer or document the alternate path where the mirror is deployed
directly under the multisig and no later ownership transfer is performed.
In `@script/FeeSchedules.sol`:
- Around line 83-115: Update _integrators to avoid assigning the Ethereum-only
SEAL Safe to Base, Arbitrum, or Robinhood: use confirmed usable per-chain SEAL
recipients for those chain IDs, or reject those deployments until recipients are
confirmed. Preserve the 2-BPS SEAL allocation and ensure Ethereum continues
using its confirmed recipient.
In `@src/interfaces/IUniswapV2Pair.sol`:
- Around line 6-10: Add NatSpec documentation directly to the
IUniswapV2Pair.mint function, including a `@notice` or `@dev` description, an `@param`
tag for to, and a `@return` tag describing liquidity. Keep the existing function
signature and interface behavior unchanged.
In `@test/integration/GovernanceIntegration.t.sol`:
- Around line 164-167: The mock participation distributor callback must pull
BWLK rather than only recording the requested amount. Update the mock method
surrounding lastEpoch and lastAmount to transferFrom the governance contract
using the provided bwlkAmount, then update the related test assertions to verify
the distributor’s BWLK balance increases by that amount and therefore exercises
the allowance.
In `@test/unit/BoostBurn.t.sol`:
- Around line 115-116: Add descriptive failure messages to the changed balance,
score, and cost assertions in the relevant BoostBurn tests, including the
assertions around bwlk balances and the additional locations noted in the
review. Ensure each message identifies the value and expected behavior being
validated.
In `@test/unit/DeployConfigs.t.sol`:
- Around line 154-193: Extend test_CrossChainConfig_PinsLaneLiterals to assert
lifiSelector and hasSourceSwaps for every supported source chain, and add
vm.expectRevert coverage when querying lane configuration for Ethereum and
removed chains. Preserve the existing literal assertions and verify that
Ethereum remains without a source lane.
In `@test/unit/GovernanceVoter.t.sol`:
- Around line 1436-1441: Extend
test_Execute_Option4_CallsParticipationDistributor to assert
mockParticipationDistributor.lastEpoch and lastAmount after voter.execute,
verifying Option 4 creates the expected BWLK stream with the configured epoch
and amount.
---
Nitpick comments:
In `@script/02_DeployFactory.s.sol`:
- Around line 38-49: Standardize the keeper environment-variable name across
both deployment scripts: keep script/02_DeployFactory.s.sol lines 38-49 using
KEEPER, and update script/test/01_TestDeploy.s.sol lines 28-55 to read KEEPER
instead of KEEPER_ADDRESS. Ensure both scripts use the same variable for the
keeper address.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7290a5cd-27ad-4869-ad7e-bdf90f1b0e6b
📒 Files selected for processing (75)
AGENTS.mdREADME.mdSPEC.mdscript/01_DeployDEX.s.solscript/02_DeployFactory.s.solscript/03_DeployGovernance.s.solscript/04_DeployNFTBridge.s.solscript/05_AddLockboxPeer.s.solscript/05_WireLockboxPeers.s.solscript/06_DeployRevenueBridging.s.solscript/CCIPConfig.solscript/CrossChainConfig.solscript/DexConfig.solscript/FeeSchedules.solscript/bwlk/02_DeployBwlkGovernance.s.solscript/bwlk/04_AssertBwlkDeploy.s.solscript/test/01_TestDeploy.s.solscript/test/02_TestExpressLaunch.s.solscript/test/04_TestAdvancedLaunch.s.solscript/test/06_TestGovernanceDeploy.s.solscript/test/07_TestGovernanceVoteAndExecute.s.solscript/test/BaseTestScript.s.solscript/test/DryRunAll.s.solsrc/core/BoardwalkFeeCollector.solsrc/core/BoostBurn.solsrc/core/LaunchFactory.solsrc/core/PresaleManager.solsrc/crosschain/EthereumRevenueSwapper.solsrc/crosschain/RevenueBridger.solsrc/dex/core/UniswapV2ERC20.solsrc/dex/core/UniswapV2Factory.solsrc/dex/core/UniswapV2Pair.solsrc/dex/core/interfaces/IERC20.solsrc/dex/core/interfaces/IUniswapV2Callee.solsrc/dex/core/interfaces/IUniswapV2ERC20.solsrc/dex/core/interfaces/IUniswapV2Factory.solsrc/dex/core/interfaces/IUniswapV2Pair.solsrc/dex/core/libraries/Math.solsrc/dex/core/libraries/SafeMath.solsrc/dex/core/libraries/UQ112x112.solsrc/dex/periphery/UniswapV2Router02.solsrc/dex/periphery/interfaces/IERC20.solsrc/dex/periphery/interfaces/IUniswapV2Router01.solsrc/dex/periphery/interfaces/IUniswapV2Router02.solsrc/dex/periphery/interfaces/IWETH.solsrc/dex/periphery/libraries/SafeMath.solsrc/dex/periphery/libraries/TransferHelper.solsrc/dex/periphery/libraries/UniswapV2Library.solsrc/governance/GovernanceVoter.solsrc/governance/ParticipationDistributor.solsrc/interfaces/IEthereumRevenueSwapper.solsrc/interfaces/ILaunchFactory.solsrc/interfaces/IParticipationDistributor.solsrc/interfaces/IRevenueBridger.solsrc/interfaces/IRewardTracker.solsrc/interfaces/IUniswapV2Pair.solsrc/token/BWLK.soltest/fork/BwlkEthereumDeployFork.t.soltest/fork/CrossChainBridging.fork.t.soltest/fork/GovernanceVoterFork.t.soltest/gas/GasBenchmarks.t.soltest/integration/FullLaunchFlow.t.soltest/integration/GovernanceIntegration.t.soltest/integration/IntegrationBase.t.soltest/invariant/GovernanceInvariant.t.soltest/unit/BoardwalkFeeCollector.t.soltest/unit/BoostBurn.t.soltest/unit/BwlkDeployAssertion.t.soltest/unit/DeployConfigs.t.soltest/unit/EthereumRevenueSwapper.t.soltest/unit/GovernanceVoter.t.soltest/unit/LaunchFactory.t.soltest/unit/ParticipationDistributor.t.soltest/unit/RevenueBridger.t.soltest/unit/RevenueBridgingDeployGuard.t.sol
💤 Files with no reviewable changes (22)
- src/dex/core/interfaces/IERC20.sol
- src/dex/core/libraries/UQ112x112.sol
- src/dex/core/interfaces/IUniswapV2Factory.sol
- src/dex/periphery/interfaces/IWETH.sol
- src/dex/core/interfaces/IUniswapV2Pair.sol
- src/dex/periphery/interfaces/IERC20.sol
- src/dex/periphery/interfaces/IUniswapV2Router02.sol
- src/dex/core/libraries/SafeMath.sol
- src/dex/core/interfaces/IUniswapV2Callee.sol
- src/dex/core/interfaces/IUniswapV2ERC20.sol
- src/dex/core/UniswapV2Factory.sol
- src/dex/periphery/libraries/TransferHelper.sol
- src/dex/core/UniswapV2ERC20.sol
- src/dex/core/libraries/Math.sol
- script/05_WireLockboxPeers.s.sol
- script/03_DeployGovernance.s.sol
- script/01_DeployDEX.s.sol
- src/dex/periphery/interfaces/IUniswapV2Router01.sol
- src/dex/periphery/libraries/UniswapV2Library.sol
- src/dex/periphery/libraries/SafeMath.sol
- src/dex/core/UniswapV2Pair.sol
- src/dex/periphery/UniswapV2Router02.sol
🚧 Files skipped from review as they are similar to previous changes (4)
- src/token/BWLK.sol
- test/fork/BwlkEthereumDeployFork.t.sol
- test/unit/BwlkDeployAssertion.t.sol
- script/bwlk/04_AssertBwlkDeploy.s.sol
…lback A forgotten NFT_COLLECTION on a spoke silently deployed the deprecated soulbound BoardwalkClub and wired it into LaunchFactory + BoostBurn membership gating, costing a 7-day SET_NFT_COLLECTION timelock on both contracts to fix. Every chain now has a proper collection (SeaDrop on Base, a CCIP mirror on spokes), so the env is required (fail-loud; an explicit zero still disables discounts) and the fallback deploy + MINT_RECIPIENTS airdrop path is removed. Also clarify the DEX env-override comment: overrides serve fork rehearsals with a nonstandard v2 deployment; FeeSchedules.resolve pins the supported chain set regardless of override order.
…ng from review The confirmed SEAL address is a Gnosis Safe with code on Ethereum only; a codeless contract wallet can neither claim nor rotate its frozen slot, so FeeSchedules now pins it on Ethereum and leaves the slot PENDING elsewhere. The deploy script fills pending slots from per-slot envs (DefiLlama Research everywhere, SEAL_ADDRESS off-Ethereum) and fails loudly when unset. Also from review: NatSpec on IUniswapV2Pair.mint; the integration PD mock now pulls BWLK like the production distributor (exercises the voter's approval path) with a balance-delta assertion; option-4 unit test asserts the stream epoch/amount; descriptive messages on the BoostBurn assertions; the NFT-bridge ownership comment documents both OWNER paths.
Convert dense prose to scannable structure with no normative content lost: - Quick-facts table up top (chains, DEX, fees, splits, graduation). - New diagrams: presale lifecycle, NFT bridge hub-and-spoke, revenue bridging flow, governance weekly cycle. - Tables replace prose walls: tax phases, fee buckets with bounds and routing, integrator slots, claim rate limits, NFT delivery failure modes, Across calldata pinning, per-leg trust model, BWLK supply split. - Deduplicate (referrer carve-out, INTEGRATOR_BPS immutability, presale lifecycle repeated in cross-contract flows) and drop analysis that isn't spec (claim-cap equilibrium math). - Option 3 mechanics move out of the vote-options table into their own paragraph so the table stays one line per option.
Fix claims that drifted from code: - Presale identifiers are weightedContributed/totalWeightedRaise (the weightedWeth names never existed post-generic-raise-token). - Seeding mints LP to the PresaleManager and then transfers it to dead; pair.mint(DEAD_ADDRESS) was never the mechanism. - Advanced vesting is required below 50% presale and forbidden at exactly 50%; the presale window itself is admin-tunable within 5-50%. - VestingStream's exemption is conditional on the launch having vesting. - Interface carve-out list: drop the nonexistent IOFT, add the CCA-launch mirrors (ILiquidityLauncher/ILBPStrategy/ICcaAuction/ICcaAuctionFactory/ IPermit2) and name them as the byte-identical-struct obligations. - Review commands are /audit, /integration-check, /write-tests (bare names). - Real deploy-script example instead of the phantom script/Deploy.s.sol. Add what a first-time agent needs: - Config-library index + docs/prod-deployment.txt pointer and a live-on-mainnet warning for src/token, src/governance, script/bwlk. - via_ir=true and its testing gotchas (absolute warps; prank-consuming inlined getters); fork tests self-skip without RPC envs. - CI installs unpinned latest-stable forge and gates fmt --check. - Build order completed: base libs, BoostBurn, BWLK token set, governance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Arbitrum BWS auction did not graduate; the launch is being redone on Ethereum mainnet under the new ticker BWLK. This PR carries the full retarget:
BWS.sol -> BWLK.sol,BwsMigration.sol -> BwlkMigration.sol,UnsoldBurner.sol, plus their interfaces. Reverse-applyingbwlk -> bwsto each renamed file reproduces the audited source byte-for-byte (verifiable withsed 's/BWLK/BWS/g; s/Bwlk/Bws/g; s/bwlk/bws/g' <file> | diff - <(git show 'af172cc:<old path>')). No error or event names contained the ticker, so no selectors or topics change beyond the intentionally renamed public getters.script/bws/->script/bwlk/,ArbitrumConfig->EthereumConfig: chain id 1; mainnet WETH / UniversalRouter / PositionManager / PoolManager; the v3.1.0 LiquidityLauncher + LBPStrategy (0x49380c4E...E6000) and itsinitializerFactory()(0x000000001F26...63F8) - all verified live on-chain, mutually consistent, struct layouts field-identical to the v3.1.0 sources.CCA_ZERO_GRADUATION_ATTESTED=true. Floor/tick are required envs until the BWLK floor is announced.block.number, so the simulation shim and the--skip-simulationbroadcast requirement are gone; fork tests drive the clock withvm.roll.BMX_ADDRESSis now required in scripts 03/04 (the Ethereum-side migration source is being re-scoped).Testing
forge fmt --checkclean under CI's forge 1.7.1.migrate-> v4 pool init -> LP minted to LPLocker ->registerPosition-> unsold burn.Reviewer notes
Summary by CodeRabbit
New Features
Updates
Tests