Skip to content

Added test requests for cookies and few improvements in testbench #4709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ramki-bruno
Copy link
Collaborator

@ramki-bruno ramki-bruno commented May 19, 2025

  • Test request to test set-cookie and cookie headers in request
  • Test request to test Secure flag for cookies in localhost and loopback IP-addresses
  • Added support for customising response status-code in POST /api/echo/custom API using statusCode field
  • Added /api/echo/trace API which returns all the request details as
    an JSON response
  • Added SSL support for localhost in dev env to test HTTPS requests
  • Fix few failing tests which rely on the selected env name being Prod and fails when Local is selected
  • Fix: XML body-parser in testbench server is giving error
  • Modified CLI-Test workflow to use its own testbench server

Copy link

github-actions bot commented May 19, 2025

Test Results

  1 files  ± 0  121 suites  +8   1m 0s ⏱️ +25s
184 tests +10  177 ✅ +6  0 💤 ±0  5 ❌ +3  2 🔥 +1 
242 runs  +10  234 ✅ +6  1 💤 ±0  5 ❌ +3  2 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit d7cde7d. ± Comparison against base commit 178773d.

♻️ This comment has been updated with latest results.

@ramki-bruno ramki-bruno force-pushed the test/cookies-testbench branch 3 times, most recently from 7845a5f to f8e8869 Compare May 20, 2025 07:48
@ramki-bruno ramki-bruno marked this pull request as ready for review May 20, 2025 07:52
@ramki-bruno ramki-bruno changed the title Added test requests for cookies + related changes in testbench server Added test requests for cookies and few improvements in testbench May 20, 2025
@ramki-bruno ramki-bruno force-pushed the test/cookies-testbench branch from f8e8869 to 5accf92 Compare May 20, 2025 08:09
@ramki-bruno ramki-bruno requested review from lohxt1, helloanoop and lohit-bruno and removed request for lohxt1 May 20, 2025 08:12
@ramki-bruno ramki-bruno force-pushed the test/cookies-testbench branch from 5accf92 to 721fc06 Compare May 20, 2025 09:38
@ramki-bruno ramki-bruno force-pushed the test/cookies-testbench branch from 721fc06 to 2960e17 Compare May 20, 2025 13:27
@ramki-bruno ramki-bruno marked this pull request as draft May 22, 2025 12:48
@ramki-bruno ramki-bruno force-pushed the test/cookies-testbench branch from 2960e17 to ca2095d Compare May 22, 2025 14:10
@ramki-bruno ramki-bruno marked this pull request as ready for review May 22, 2025 14:10
@ramki-bruno ramki-bruno force-pushed the test/cookies-testbench branch from ca2095d to c4cbf2f Compare May 22, 2025 14:36
In bruno-testbench(packages/bruno-tests) server
- Added support for customising response status-code in
`POST /api/echo/custom` API using `statusCode` field
- Added `/api/echo/trace` API which returns all the request details as
  an JSON response
- Added SSL support for `localhost` in dev env to test HTTPS requests
@ramki-bruno
Copy link
Collaborator Author

ramki-bruno commented May 27, 2025

image

These require the latest testbench server code in the server.

@ramki-bruno
Copy link
Collaborator Author

These require the latest testbench server code in the server.

These tests are actually for testing the behavior of cookies in a non-local host. There is way to even route these back to local server by adding an entry in /etc/hosts. Will do that in a follow up PR where we can completely switch to Local env. All that will be out of scope for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants