-
Notifications
You must be signed in to change notification settings - Fork 0
MOB-19785 | Update Demo App #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AktasBedirInsider
wants to merge
9
commits into
main
Choose a base branch
from
feature/MOB-19785
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+13,663
−6,224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated plugins/cordova-plugin-insider from NPM (3.0.2) - Rebuilt www/ folder with babel to reflect SDK_VERSION: 'CDV-3.0.2' - Previous version was showing 'CDV-1.4.0' in www/Constants.js
e4275ea to
b1db4df
Compare
- Downgrade cordova-ios from 8.0.0 to 6.2.0 to maintain notification extensions - Build Android and iOS platforms with updated plugin version - Update plugin files in platform directories
- Add notification extension targets to Podfile with proper dependencies - Update pod versions to 14.0.4 (InsiderMobile), 1.2.3 (InsiderGeofence), 1.7.5 (InsiderHybrid) - Add NSUserTrackingUsageDescription to Info.plist to fix iOS 14+ crash - Remove Pods/ and Podfile.lock from repository (auto-generated files) - Add Pods/ and Podfile.lock to .gitignore - Restore notification extension targets in Xcode project
- Remove local git clone version - Install clean NPM package (v3.0.2) - Removes development files (.github/, devops/, example/) - Ensures partners get same clean structure as published package
melih-useinsider
approved these changes
Dec 17, 2025
ozgur-useinsider
requested changes
Jan 8, 2026
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I follow all the instructions in README.md for iOS, I get:
Could not load API for ios project /Users/ozgur.vatansever/Developer/Insider/Demo/CordovaDemo/platforms/ios/cordova/Api.js
after I run cordova run ios.
I have cordova 12.0.0 ([email protected])
damlayagmur
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing, make sure you have:
🔴 [Mandatory] Description
This PR updates the CordovaDemo application to match feature parity with ReactNativeDemo by upgrading to insider-cordova-plugin 3.0.2 and implementing all available SDK methods. The update includes 13 new methods across user management, events, products, smart recommendations, content optimizer, and in-app messaging features.
🔴 [Mandatory] What's the change?
Package Updates
^1.4.0→^3.0.2^10.1.2→^14.0.1^6.2.0→^8.0.0UI Enhancements
File:
www/index.htmlAdded Buttons (10 total)
User Identifiers
Smart Recommender
Mobile App Access
Content Optimizer
In-App Messages
SDK Integration
File:
www/js/index.jsNew Methods Implemented (13 total)
logoutResettingInsiderID()
Reset Insider ID on logout
signUpConfirmation()
Track user registration
setMobileAppAccess()
Control mobile app access
removeInapp()
Remove in-app messages
getSmartRecommendationWithProductIDs()
Fetch smart recommendations using product IDs
clickSmartRecommendationProduct()
Track smart recommendation product clicks
getContentOptimizerIntWithoutCache()
getContentOptimizerStringWithoutCache()
getContentOptimizerBoolWithoutCache()
Content Optimizer variable access without cache
addParameterWithStringArray()
addParameterWithNumericArray()
Event parameters with array support
setCustomAttributeWithStringArray()
setCustomAttributeWithNumericArray()
Product custom attributes with array support
Refactoring & Improvements
Smart Recommendation
getSmartRecommendationrefactored intosmartRecommendationobjecttriggerEvents()
createNewProduct()
🔴 [Mandatory] Impact Area
Scope: CordovaDemo application only
Platforms: iOS and Android
Dependencies: Cordova plugin ecosystem (android, ios, insider-cordova-plugin)
User Impact: Demo app now showcases all available SDK features from insider-cordova-plugin 3.0.2