Skip to content

feat: set locale based on browser language when user is not logged in #4635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025

Conversation

Alwayswithme
Copy link
Contributor

Description

This PR adds functionality to detect and set the locale based on the browser's language settings (navigator.language) when the user is not logged in.
Let me know if anything else needs to be updated. Thanks!

Related Issue

Closes #4557

@Alwayswithme Alwayswithme requested a review from boojack as a code owner April 17, 2025 06:14
Copy link
Collaborator

@johnnyjoygh johnnyjoygh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@johnnyjoygh johnnyjoygh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnnyjoygh johnnyjoygh merged commit 76ed1b5 into usememos:main Apr 17, 2025
2 checks passed
@Alwayswithme Alwayswithme deleted the browser_locale branch April 17, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded language when logged out
2 participants