sk-moss-plugin#134
Conversation
Adds a Python Semantic Kernel plugin that exposes Moss retrieval as a @kernel_function, letting any SK agent query a Moss index with 3 lines of code. Mirrors the strands-agents-moss integration pattern. Includes plugin implementation, 14 unit/integration tests, example, README with Quick Start and configuration docs, and TODOS.md for follow-up work (CI/CD pipeline, .NET design doc).
feat: add Semantic Kernel plugin for Moss semantic search
Abhijitam01
requested review from
CoderOMaster,
HarshaNalluru,
r4ghu and
yatharthk2
as code owners
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Aligns with the rest of the repo — all other integration packages (strands-agents-moss, elevenlabs-moss, pipecat-moss, moss-cli) depend on moss and import from moss, not inferedge-moss.
|
Thanks for the pr, can you please provide loom video demo ? |
|
is this pr still being worked upon ? |
|
hey @yatharthk2 , it totally miss the comment , i have added the loom video , you can go through it , let me know if their is anything else i can do |
| @@ -0,0 +1,21 @@ | |||
| # TODOs | |||
|
|
|||
| ## CI/CD pipeline for integration packages | |||
There was a problem hiding this comment.
this file seems unnecessary
| # SPDX-License-Identifier: BSD 2-Clause License | ||
| # | ||
|
|
||
| """Semantic Kernel plugin for Moss semantic search.""" |
There was a problem hiding this comment.
Integration is a thin wrapper on top of the moss client. can you shift this to cookbook.
I dont expect many changes in the code, just remove the package related documentation and import functions directly from the files instead of the package
| moss = MossPlugin( | ||
| project_id=os.getenv("MOSS_PROJECT_ID"), | ||
| project_key=os.getenv("MOSS_PROJECT_KEY"), | ||
| index_name=os.getenv("MOSS_INDEX_NAME", "my-index"), |
There was a problem hiding this comment.
please add .env.example
|
over all code/logic looks good, I think we will be able to merge after one more iteration of review |
|
is this pr being worked upon ? |
3 participants
Pull Request Checklist
Please ensure that your PR meets the following requirements:
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue number)
Type of Change
Loom Video - https://www.loom.com/share/ad952712a2864eb082086ad3e26a1aa5