Optimize of Activity feed and Contact search query #204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Contact search, we get rid of additional queries for triggers and emails, and is now done with joins. Also, we return already greatest createdAt and sort by it on the query level.
For Avtivity Feed, we do limits and offset already on the DB level, that way queries become way faster because they don't need to get all the data from the DB to the backend. To get the same format, we used to_jsonb and jsonb_build_object. For bringing triggers and emails to the same table we used UNION, for that reason, all can be done in the DB level, even pagination.
Extra small fix is
filtered.length
tocontacts.count
, where I think that the correct value that should be used.