Added enable flag for periodic task #901
Conversation
aklyuchev
force-pushed
the
feature/us900-periodic-task-enable-flag
branch
from
26b80b2 to
a4d60b2
Compare
core/src/utils/periodic_task.cpp
Outdated
| const auto settings = settings_.Read(); | ||
| taskEnabled = settings->enabled; | ||
| if(!taskEnabled) { | ||
| break; |
There was a problem hiding this comment.
Setting deadline + continue should be more straightforward and closer to existing code logic below
| task.Stop(); | ||
| } | ||
|
|
||
| UTEST(PeriodicTask, EnableDisable) { |
There was a problem hiding this comment.
Add a test that checks the task does not keep running periodically if ForceStepAsync is run while enabled=false
There was a problem hiding this comment.
This test will also check that ForceStepAsync ignores enabled
| task.Stop(); | ||
| } | ||
|
|
||
| UTEST(PeriodicTask, EnableDisable) { |
There was a problem hiding this comment.
There is a lot to decipher in this test's logic - split it into some steps with empty lines and comment on each step
| task.Stop(); | ||
| } | ||
|
|
||
| UTEST(PeriodicTask, EnableDisable) { |
There was a problem hiding this comment.
Add a test that checks that if enabled=false during Start (even if enabled=true in PeriodicTask constructor), then the first iteration won't happen immediately and won't happen after period
| task.Stop(); | ||
| } | ||
|
|
||
| UTEST(PeriodicTask, EnableDisable) { |
There was a problem hiding this comment.
Add a test that checks that SynchronizeDebug respects enabled
| task.Stop(); | ||
| } | ||
|
|
||
| UTEST(PeriodicTask, EnableDisable) { |
There was a problem hiding this comment.
Add a test that after enabled=false + enabled=on the task does not always start an iteration instantly, but awaits the configured interval since the last time it was run
3 participants
Added enable flag for periodic task
Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.