-
-
Notifications
You must be signed in to change notification settings - Fork 216
delete-domain route added #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
133145a
delete-domain route added in public-API
kuntlme 22384a1
delete-domain route added in sdk
kuntlme e02b161
delete-domain route added in python-sdk
kuntlme acfccf3
delete-domain route added in docs
kuntlme 5407a8d
fix: apply review suggestions for delete domain feature
kuntlme f106574
fix: resolve review suggestions
kuntlme cb95486
403 & 404 error response added in delete route
kuntlme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
--- | ||
openapi: delete /v1/domains/{id} | ||
--- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
apps/web/src/server/public-api/api/domains/delete-domain.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
import { createRoute, z } from "@hono/zod-openapi"; | ||
import { PublicAPIApp } from "../../hono"; | ||
import { db } from "~/server/db"; | ||
import { UnsendApiError } from "../../api-error"; | ||
import { deleteDomain as deleteDomainService } from "~/server/service/domain-service"; | ||
|
||
const route = createRoute({ | ||
method: "delete", | ||
path: "/v1/domains/{id}", | ||
request: { | ||
params: z.object({ | ||
id: z.coerce.number().openapi({ | ||
param: { | ||
name: "id", | ||
in: "path", | ||
}, | ||
example: 1, | ||
}), | ||
}), | ||
}, | ||
responses: { | ||
200: { | ||
content: { | ||
"application/json": { | ||
schema: z.object({ | ||
success: z.boolean(), | ||
message: z.string(), | ||
}), | ||
}, | ||
}, | ||
description: "Domain deleted successfully", | ||
}, | ||
403: { | ||
kuntlme marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"application/json": { | ||
schema: z.object({ | ||
error: z.string(), | ||
}), | ||
}, | ||
description: "Forbidden - API key doesn't have access", | ||
}, | ||
404: { | ||
content: { | ||
"application/json": { | ||
schema: z.object({ | ||
error: z.string(), | ||
}), | ||
}, | ||
}, | ||
description: "Domain not found", | ||
}, | ||
} | ||
}) | ||
|
||
function deleteDomain(app: PublicAPIApp) { | ||
app.openapi(route, async (c) => { | ||
const team = c.var.team; | ||
const domainId = c.req.valid("param").id; | ||
|
||
// Enforce API key domain restriction | ||
if (team.apiKey.domainId && team.apiKey.domainId !== domainId) { | ||
throw new UnsendApiError({ | ||
code: "FORBIDDEN", | ||
message: "API key doesn't have access to this domain", | ||
}); | ||
} | ||
|
||
const domain = await db.domain.findFirst({ | ||
where: { | ||
id: domainId, | ||
teamId: team.id | ||
}, | ||
}); | ||
|
||
if (!domain) { | ||
throw new UnsendApiError({ | ||
code: "NOT_FOUND", | ||
message: "Domain not found", | ||
}); | ||
} | ||
|
||
const deletedDomain = await deleteDomainService(domainId); | ||
|
||
return c.json(deletedDomain); | ||
}); | ||
} | ||
|
||
export default deleteDomain; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.