-
-
Notifications
You must be signed in to change notification settings - Fork 216
update package version and response return tyupe for delete domain api #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Caution Review failedThe pull request is closed. WalkthroughThis PR updates domain API schemas and SDK types. In OpenAPI, domain responses are simplified, DELETE /v1/domains/{id} path id becomes nullable and not required, and error bodies are reduced to an "error" string. Web route for delete-domain now returns { id, success, message } and defines 403/404 payloads. Docs navigation adds the delete-domain page and formatting changes. Python SDK: version bump, new DomainDeleteResponse type, and Domains.delete return type updated. JS SDK: version bump and schema.d.ts changes reflecting the new response shapes, including replacing dnsRecords in GET /v1/domains with success/message. Possibly related PRs
Suggested labels
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 8 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/docs/api-reference/openapi.json">
<violation number="1" location="apps/docs/api-reference/openapi.json:632">
Path parameters that appear in the URL template must remain required—setting `id` to optional makes the specification invalid for `/v1/domains/{id}`. Please keep the path parameter required so generated clients and validators work correctly.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
"example": 1 | ||
}, | ||
"required": true, | ||
"required": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Path parameters that appear in the URL template must remain required—setting id
to optional makes the specification invalid for /v1/domains/{id}
. Please keep the path parameter required so generated clients and validators work correctly.
Prompt for AI agents
Address the following comment on apps/docs/api-reference/openapi.json at line 632:
<comment>Path parameters that appear in the URL template must remain required—setting `id` to optional makes the specification invalid for `/v1/domains/{id}`. Please keep the path parameter required so generated clients and validators work correctly.</comment>
<file context>
@@ -626,10 +626,10 @@
"example": 1
},
- "required": true,
+ "required": false,
"name": "id",
"in": "path"
</file context>
"required": false, | |
"required": true, |
Summary by cubic
Standardized the Delete Domain API to return a minimal status payload and updated SDKs and docs to match. This makes the response consistent and easier to handle across clients.
Refactors
Dependencies
Summary by CodeRabbit