Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed category of ConcreteHole production and regenerated Rascal parser #2201

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

rodinaarssen
Copy link
Member

Semantic highlighting of metavariables in concrete patterns was not working due to an incorrect category in the Rascal grammar. This PR contains a fix and a regenerated Rascal parser (the bootstrap did not change the AST).

Fixes #2191.

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46%. Comparing base (44c357a) to head (e400032).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2201   +/-   ##
=======================================
  Coverage       46%     46%           
- Complexity    6213    6216    +3     
=======================================
  Files          758     758           
  Lines        63070   63070           
  Branches      9419    9419           
=======================================
+ Hits         29554   29565   +11     
+ Misses       31319   31303   -16     
- Partials      2197    2202    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DavyLandman DavyLandman merged commit 3eb105f into main Mar 21, 2025
8 checks passed
@rodinaarssen rodinaarssen deleted the fix-concrete-hole-category branch March 21, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Holes in concrete syntax have wrong category
2 participants