Skip to content

Fixed Firefox issues #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Fixed Firefox issues #351

merged 2 commits into from
Jan 13, 2025

Conversation

chuanlin2018
Copy link
Collaborator

This branch fixes two issues:

  1. When expand/collapse filter items, white space added to the top area of landing page. This issue only happened in Firefox.
  2. Search result return nothing if taxonomy tag contains comma.

Issue #1 was because of a Firefox bug related to sticky styling. The fix was to use absolute position and dynamic position.

Issue #2 was fixed by replacing filter string with object.

Tested locally in Chrome, Firefox and Safari. Not tested in docker because had some issues running docker locally even integration branch - rmm had problem accessing Mongodb.

Copy link
Collaborator

@RayPlante RayPlante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on testdata, confirmed the follow fixed under firefox:

  • Grand Challenge filters work properly
  • Opening up a filter does not insert extra space at the top of the page
  • Research areas list wrap properly now.

@RayPlante RayPlante merged commit 78107e6 into integration Jan 13, 2025
2 checks passed
@RayPlante RayPlante deleted the fix-firefox branch January 13, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants