Skip to content

Fixed download and shoping cart logic to handle restrict data corectl… #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

chuanlin2018
Copy link
Collaborator

This branch has two changes:

  1. Applied following logic to the download and shopping cart icons in the data file table:
    In Nerdm record, if a component has download URL, display download icon and shopping cart icon. Otherwise display a lock icon.
  2. Moved the badge styling to landing page css so the two badges will share the same styling: one is the shopping cart at the top right corner; the other is the shopping cart above the data file table.

…y; Moved badge styling to landingpage styling.
Copy link
Collaborator

@RayPlante RayPlante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. I'll note thought that the lock icon used to be a link that opens up the restricted access page, just like the "Request Data Access" button which is preferable.

@RayPlante RayPlante merged commit 2c2e701 into integration Mar 4, 2025
2 checks passed
@RayPlante RayPlante deleted the fix/restrict-public branch March 4, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants