[WIP] Fit json loader into resource container protocol #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed off by: @victordomiciano Signed off by: @Kazuo256 Signed off by: @josealvim
Kazuo256
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready to merge yet.
We need to:
ResourceLoader<T>class which is to be overloaded for the appropriate typesResourceContainer<T>to delegate resource loading to the correspondingResourceLoader<T>ResourceLoader<SpriteAnimationTable>while movingaction/json2spriteanimation.hout of the public API.This way, the default loader for animation tables becomes the JSON loader, but the developer can still pass their own loader to
ResourceLoader.