Implemented multi-row class parsing for subgroups and fixed data.json#67
Open
iakshatkaushik wants to merge 1 commit into
Open
Implemented multi-row class parsing for subgroups and fixed data.json#67iakshatkaushik wants to merge 1 commit into
iakshatkaushik wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… creationThis pull request introduces significant improvements to how the timetable generator parses data from the
timetable.xlsxExcel file.Key Changes:
utils/genData.goto correctly read and extract class subgroups (e.g., "2C11", "2C12") from row 5 of the Excel sheets, while still respecting the main group headers in row 4. This addresses scenarios where class sections are listed in a hierarchical manner across multiple rows.utils/genData.gohas been made more flexible to accurately identify class/subgroup names by filtering out common non-class headers (like "BRANCH", "LECTURE", "TUTORIAL") that might appear in the header rows.data.jsonCreation: Updatedutils/genData.goto useos.Createwhen generatingdata.json, resolving "no such file or directory" errors and ensuring the JSON output file is always correctly created or overwritten.startRowconstant inutils/data.gohas been updated from7to8to correctly align with the actual start of timetable data in the provided Excel files.Why these changes?
These updates are crucial for accurately processing timetable Excel files that use a two-row structure for defining main classes and their respective subgroups. This ensures that all available class sections are correctly identified and displayed in the web application, making the tool more versatile for different timetable formats.
This resolves the issue where only main groups were visible and subgroups were missing from the selection options.